QVAC-17990 Add standalone ESRGAN upscaler API#1901
Merged
Conversation
aegioscy
requested changes
May 5, 2026
Contributor
Tier-based Approval Status |
jesusmb1995
requested changes
May 7, 2026
gianni-cor
requested changes
May 7, 2026
aegioscy
approved these changes
May 7, 2026
aegioscy
requested changes
May 7, 2026
gianni-cor
reviewed
May 8, 2026
gianni-cor
left a comment
Contributor
There was a problem hiding this comment.
One more observation while comparing the diffusion-cpp JS contract against qvac-lib-infer-llamacpp-llm. Not blocking — flagging for a follow-up.
Preview deployments for qvac-docs-staging ⚡️
Commit: Deployment ID: Static site name: |
Add a standalone-esrgan-upscale example and a README usage section covering the new EsrganUpscaler named export. The previous CHANGELOG entry was the only user-facing reference to the new public class; this commit makes it discoverable from the README index, the Other Examples list, and a runnable example script that mirrors the existing generate-image-esrgan-upscale flow but without the diffusion phase.
aegioscy
approved these changes
May 8, 2026
gianni-cor
approved these changes
May 8, 2026
Contributor
|
/review |
Contributor
|
/review |
jesusmb1995
approved these changes
May 8, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a standalone ESRGAN upscaler API to
@qvac/diffusion-cpp.This allows callers to upscale existing encoded image bytes without loading or running a diffusion model.
New public API:
Additional PR details
Implemented:
EsrganUpscalerrepeatssupport with positive integer validationfiles.esrganvalidation without requiringfiles.modelValidation
Results:
Skipped C++ tests require local FLUX2 img2img assets and are unrelated to this PR.
Notes