Skip to content

ci(workflows): unblock LLM PR trigger by trimming comments in oversized run block#1891

Merged
gianni-cor merged 1 commit into
tetherto:mainfrom
gianni-cor:hotfix/llm-workflow-expr-limit
May 4, 2026
Merged

ci(workflows): unblock LLM PR trigger by trimming comments in oversized run block#1891
gianni-cor merged 1 commit into
tetherto:mainfrom
gianni-cor:hotfix/llm-workflow-expr-limit

Conversation

@gianni-cor

@gianni-cor gianni-cor commented May 4, 2026

Copy link
Copy Markdown
Contributor

🎯 What problem does this PR solve?

  • On PR Trigger (LLM) is currently broken on main for every PR that touches the LLM package. Example failure: run 25332266722.
  • After Create new buckets to run tests in independent processes #1889 was merged, the Create and Upload Test Spec step's run: | block in .github/workflows/integration-mobile-test-qvac-lib-infer-llamacpp-llm.yml reached 21,074 chars (YAML-parsed) — 74 over GitHub Actions' 21,000-char single-expression limit.
  • Because the LLM trigger uses pull_request_target + workflow_call into that file (loaded from main), the parser fails fleet-wide with:
    (Line: 914, Col: 14): Exceeded max expression length 21000
    
    No jobs run; the workflow exits with failure and 0 billable seconds.
  • Currently blocked PRs include Sync with latest fabric-8189 version on LLM/Embed/NMT  #1874 (Qwen3.5 / Gemma4 / PaddleOCR-VL tests) and several others.

📝 How does it solve it?

  • Removes 32 in-block comment lines from the offending step's run: | block — pure prose, no logic changes.
  • Comment groups removed (all inside the Create and Upload Test Spec step):
    • 4 lines narrating per-platform branching
    • 7 lines describing Android crash detection / placeholder substitution
    • 1 line about iOS host (macos_sequoia) requirement
    • 15 lines describing iOS crash flow / WDA / timeout
    • 5 lines describing per-split make_split injection
  • Brings the YAML-parsed run: payload from 21,074 → 19,008 chars (1,992 under the 21k limit).
  • Diff: +0 / -32.

🧪 How was it tested?

  • Re-parsed the post-edit workflow file and confirmed the largest run: block is now 19,008 chars vs the 21,000 limit.
  • Verified diff against upstream/main is comments-only (git diff --stat: 32 deletions, 0 insertions).
  • Behavior the comments described (5 s setTimeout exit, flushBareLog Appium pull_file, __TEST_FILTER__ / __QVAC_PERF_* placeholder substitution, etc.) is unchanged — the step still runs the same shell, generates the same testspec YAMLs, and uploads to the same Device Farm project.
  • Real validation will come from On PR Trigger (LLM) actually starting jobs on this PR (which is the failing path on main).

🔭 Follow-up (not in this PR)

The "Create and Upload Test Spec" step's run: | block in
integration-mobile-test-qvac-lib-infer-llamacpp-llm.yml grew to
21,074 chars after tetherto#1889, putting it just over GitHub Actions'
21,000-char limit on a single template expression.

This breaks every reusable-workflow_call into the file, so the
On PR Trigger (LLM) workflow fails instantly with:

  error parsing called workflow ... :
  (Line: 914, Col: 14): Exceeded max expression length 21000

and no jobs run. Every open PR that touches the LLM package is
currently blocked from getting LLM CI.

Fix: remove 32 in-block comment lines that were pure narration of
already-readable code (echo/printf/sed) and verbose intent text
duplicated by the surrounding context. Brings the run-block payload
to ~19,008 chars (well under 21,000) without changing any executed
logic.

Diff is comments-only: 32 deletions, 0 additions.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gianni-cor gianni-cor requested a review from a team as a code owner May 4, 2026 17:16
@gianni-cor

Copy link
Copy Markdown
Contributor Author

/review

1 similar comment
@gianni-cor

Copy link
Copy Markdown
Contributor Author

/review

@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ❌ (0/1)
- 1 Team Lead OR Management approval ✅ (2/1)

**Bypass rule:** Triggered (2+ Team Lead approvals (Tier 1 exception)). This PR is approved regardless of tier.

---
*This comment is automatically updated when reviews change.*

@gianni-cor

Copy link
Copy Markdown
Contributor Author

/review

@gianni-cor gianni-cor merged commit 0cc9b32 into tetherto:main May 4, 2026
4 of 6 checks passed
tamer-hassan-tether pushed a commit that referenced this pull request May 5, 2026
)

The "Create and Upload Test Spec" step's run: | block in
integration-mobile-test-qvac-lib-infer-llamacpp-llm.yml grew to
21,074 chars after #1889, putting it just over GitHub Actions'
21,000-char limit on a single template expression.

This breaks every reusable-workflow_call into the file, so the
On PR Trigger (LLM) workflow fails instantly with:

  error parsing called workflow ... :
  (Line: 914, Col: 14): Exceeded max expression length 21000

and no jobs run. Every open PR that touches the LLM package is
currently blocked from getting LLM CI.

Fix: remove 32 in-block comment lines that were pure narration of
already-readable code (echo/printf/sed) and verbose intent text
duplicated by the surrounding context. Brings the run-block payload
to ~19,008 chars (well under 21,000) without changing any executed
logic.

Diff is comments-only: 32 deletions, 0 additions.

Co-authored-by: Cursor <cursoragent@cursor.com>
tamer-hassan-tether pushed a commit that referenced this pull request May 6, 2026
)

The "Create and Upload Test Spec" step's run: | block in
integration-mobile-test-qvac-lib-infer-llamacpp-llm.yml grew to
21,074 chars after #1889, putting it just over GitHub Actions'
21,000-char limit on a single template expression.

This breaks every reusable-workflow_call into the file, so the
On PR Trigger (LLM) workflow fails instantly with:

  error parsing called workflow ... :
  (Line: 914, Col: 14): Exceeded max expression length 21000

and no jobs run. Every open PR that touches the LLM package is
currently blocked from getting LLM CI.

Fix: remove 32 in-block comment lines that were pure narration of
already-readable code (echo/printf/sed) and verbose intent text
duplicated by the surrounding context. Brings the run-block payload
to ~19,008 chars (well under 21,000) without changing any executed
logic.

Diff is comments-only: 32 deletions, 0 additions.

Co-authored-by: Cursor <cursoragent@cursor.com>
Proletter pushed a commit that referenced this pull request May 24, 2026
)

The "Create and Upload Test Spec" step's run: | block in
integration-mobile-test-qvac-lib-infer-llamacpp-llm.yml grew to
21,074 chars after #1889, putting it just over GitHub Actions'
21,000-char limit on a single template expression.

This breaks every reusable-workflow_call into the file, so the
On PR Trigger (LLM) workflow fails instantly with:

  error parsing called workflow ... :
  (Line: 914, Col: 14): Exceeded max expression length 21000

and no jobs run. Every open PR that touches the LLM package is
currently blocked from getting LLM CI.

Fix: remove 32 in-block comment lines that were pure narration of
already-readable code (echo/printf/sed) and verbose intent text
duplicated by the surrounding context. Brings the run-block payload
to ~19,008 chars (well under 21,000) without changing any executed
logic.

Diff is comments-only: 32 deletions, 0 additions.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants