ci(workflows): unblock LLM PR trigger by trimming comments in oversized run block#1891
Merged
gianni-cor merged 1 commit intoMay 4, 2026
Merged
Conversation
The "Create and Upload Test Spec" step's run: | block in integration-mobile-test-qvac-lib-infer-llamacpp-llm.yml grew to 21,074 chars after tetherto#1889, putting it just over GitHub Actions' 21,000-char limit on a single template expression. This breaks every reusable-workflow_call into the file, so the On PR Trigger (LLM) workflow fails instantly with: error parsing called workflow ... : (Line: 914, Col: 14): Exceeded max expression length 21000 and no jobs run. Every open PR that touches the LLM package is currently blocked from getting LLM CI. Fix: remove 32 in-block comment lines that were pure narration of already-readable code (echo/printf/sed) and verbose intent text duplicated by the surrounding context. Brings the run-block payload to ~19,008 chars (well under 21,000) without changing any executed logic. Diff is comments-only: 32 deletions, 0 additions. Co-authored-by: Cursor <cursoragent@cursor.com>
moromisato
approved these changes
May 4, 2026
GustavoA1604
approved these changes
May 4, 2026
Contributor
Author
|
/review |
1 similar comment
Contributor
Author
|
/review |
Contributor
Tier-based Approval Status |
Contributor
Author
|
/review |
donriddo
approved these changes
May 4, 2026
tamer-hassan-tether
pushed a commit
that referenced
this pull request
May 5, 2026
) The "Create and Upload Test Spec" step's run: | block in integration-mobile-test-qvac-lib-infer-llamacpp-llm.yml grew to 21,074 chars after #1889, putting it just over GitHub Actions' 21,000-char limit on a single template expression. This breaks every reusable-workflow_call into the file, so the On PR Trigger (LLM) workflow fails instantly with: error parsing called workflow ... : (Line: 914, Col: 14): Exceeded max expression length 21000 and no jobs run. Every open PR that touches the LLM package is currently blocked from getting LLM CI. Fix: remove 32 in-block comment lines that were pure narration of already-readable code (echo/printf/sed) and verbose intent text duplicated by the surrounding context. Brings the run-block payload to ~19,008 chars (well under 21,000) without changing any executed logic. Diff is comments-only: 32 deletions, 0 additions. Co-authored-by: Cursor <cursoragent@cursor.com>
tamer-hassan-tether
pushed a commit
that referenced
this pull request
May 6, 2026
) The "Create and Upload Test Spec" step's run: | block in integration-mobile-test-qvac-lib-infer-llamacpp-llm.yml grew to 21,074 chars after #1889, putting it just over GitHub Actions' 21,000-char limit on a single template expression. This breaks every reusable-workflow_call into the file, so the On PR Trigger (LLM) workflow fails instantly with: error parsing called workflow ... : (Line: 914, Col: 14): Exceeded max expression length 21000 and no jobs run. Every open PR that touches the LLM package is currently blocked from getting LLM CI. Fix: remove 32 in-block comment lines that were pure narration of already-readable code (echo/printf/sed) and verbose intent text duplicated by the surrounding context. Brings the run-block payload to ~19,008 chars (well under 21,000) without changing any executed logic. Diff is comments-only: 32 deletions, 0 additions. Co-authored-by: Cursor <cursoragent@cursor.com>
Proletter
pushed a commit
that referenced
this pull request
May 24, 2026
) The "Create and Upload Test Spec" step's run: | block in integration-mobile-test-qvac-lib-infer-llamacpp-llm.yml grew to 21,074 chars after #1889, putting it just over GitHub Actions' 21,000-char limit on a single template expression. This breaks every reusable-workflow_call into the file, so the On PR Trigger (LLM) workflow fails instantly with: error parsing called workflow ... : (Line: 914, Col: 14): Exceeded max expression length 21000 and no jobs run. Every open PR that touches the LLM package is currently blocked from getting LLM CI. Fix: remove 32 in-block comment lines that were pure narration of already-readable code (echo/printf/sed) and verbose intent text duplicated by the surrounding context. Brings the run-block payload to ~19,008 chars (well under 21,000) without changing any executed logic. Diff is comments-only: 32 deletions, 0 additions. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
On PR Trigger (LLM)is currently broken onmainfor every PR that touches the LLM package. Example failure: run 25332266722.Create and Upload Test Specstep'srun: |block in.github/workflows/integration-mobile-test-qvac-lib-infer-llamacpp-llm.ymlreached 21,074 chars (YAML-parsed) — 74 over GitHub Actions' 21,000-char single-expression limit.pull_request_target+workflow_callinto that file (loaded frommain), the parser fails fleet-wide with:failureand 0 billable seconds.Qwen3.5 / Gemma4 / PaddleOCR-VL tests) and several others.📝 How does it solve it?
run: |block — pure prose, no logic changes.Create and Upload Test Specstep):macos_sequoia) requirementmake_splitinjectionrun:payload from 21,074 → 19,008 chars (1,992 under the 21k limit).🧪 How was it tested?
run:block is now 19,008 chars vs the 21,000 limit.upstream/mainis comments-only (git diff --stat: 32 deletions, 0 insertions).setTimeoutexit,flushBareLogAppium pull_file,__TEST_FILTER__/__QVAC_PERF_*placeholder substitution, etc.) is unchanged — the step still runs the same shell, generates the same testspec YAMLs, and uploads to the same Device Farm project.On PR Trigger (LLM)actually starting jobs on this PR (which is the failing path onmain).🔭 Follow-up (not in this PR)
run:block has been creeping toward the 21k limit for a while: 19,410 (4/4 - Remove unnecessary NPM tokens #1591) → 21,103 (fix(ci): pull bare_console.log from iOS app sandbox on crash #1804, first time over) → 22,734 (QVAC-18111 infra[notask]: bridge QVAC_PERF_RUNS to mobile test app via pushFile #1840) → 23,435 (Create new buckets to run tests in independent processes #1889, full break). Comment-trim buys headroom but not much.WDIO_CONFIGJS blobs (and ideally the longprintftestspec template) into files under.github/scripts/orpackages/qvac-lib-infer-llamacpp-llm/test/mobile/andcat/sourcethem in the workflow. That permanently caps run-block size and lets the documentation comments come back in a place where they don't count against the 21k limit.