Create new buckets to run tests in independent processes#1889
Merged
Conversation
Signed-off-by: Marcus Edel <marcus.edel@collabora.com>
gianni-cor
previously approved these changes
May 4, 2026
jesusmb1995
previously approved these changes
May 4, 2026
Contributor
|
/review |
Contributor
Tier-based Approval Status |
The two RUN_ARNS aggregation loops were hardcoded to iterate over indices 2..8, so the new Heavy7/Heavy8 runs (RUN_ARN_9, RUN_ARN_10) were silently dropped from the final test-results summary and the Device Farm log download. As a result, Heavy7/Heavy8 failures would not have failed the workflow and their device logs would not have been collected. Iterate up to RUN_COUNT instead, so any future bucket additions are picked up automatically. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
/review |
gianni-cor
approved these changes
May 4, 2026
jesusmb1995
approved these changes
May 4, 2026
maxim-smotrov
approved these changes
May 4, 2026
Contributor
|
/review |
1 similar comment
Contributor
|
/review |
gianni-cor
added a commit
that referenced
this pull request
May 4, 2026
) The "Create and Upload Test Spec" step's run: | block in integration-mobile-test-qvac-lib-infer-llamacpp-llm.yml grew to 21,074 chars after #1889, putting it just over GitHub Actions' 21,000-char limit on a single template expression. This breaks every reusable-workflow_call into the file, so the On PR Trigger (LLM) workflow fails instantly with: error parsing called workflow ... : (Line: 914, Col: 14): Exceeded max expression length 21000 and no jobs run. Every open PR that touches the LLM package is currently blocked from getting LLM CI. Fix: remove 32 in-block comment lines that were pure narration of already-readable code (echo/printf/sed) and verbose intent text duplicated by the surrounding context. Brings the run-block payload to ~19,008 chars (well under 21,000) without changing any executed logic. Diff is comments-only: 32 deletions, 0 additions. Co-authored-by: Cursor <cursoragent@cursor.com>
tamer-hassan-tether
pushed a commit
that referenced
this pull request
May 5, 2026
* Create new buckets to run tests in independent processes. Signed-off-by: Marcus Edel <marcus.edel@collabora.com> * ci(ios): include all run ARNs in results aggregation and log download The two RUN_ARNS aggregation loops were hardcoded to iterate over indices 2..8, so the new Heavy7/Heavy8 runs (RUN_ARN_9, RUN_ARN_10) were silently dropped from the final test-results summary and the Device Farm log download. As a result, Heavy7/Heavy8 failures would not have failed the workflow and their device logs would not have been collected. Iterate up to RUN_COUNT instead, so any future bucket additions are picked up automatically. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Signed-off-by: Marcus Edel <marcus.edel@collabora.com> Co-authored-by: gianni-cor <gianfranco.cordella@tether.io> Co-authored-by: Cursor <cursoragent@cursor.com>
tamer-hassan-tether
pushed a commit
that referenced
this pull request
May 5, 2026
) The "Create and Upload Test Spec" step's run: | block in integration-mobile-test-qvac-lib-infer-llamacpp-llm.yml grew to 21,074 chars after #1889, putting it just over GitHub Actions' 21,000-char limit on a single template expression. This breaks every reusable-workflow_call into the file, so the On PR Trigger (LLM) workflow fails instantly with: error parsing called workflow ... : (Line: 914, Col: 14): Exceeded max expression length 21000 and no jobs run. Every open PR that touches the LLM package is currently blocked from getting LLM CI. Fix: remove 32 in-block comment lines that were pure narration of already-readable code (echo/printf/sed) and verbose intent text duplicated by the surrounding context. Brings the run-block payload to ~19,008 chars (well under 21,000) without changing any executed logic. Diff is comments-only: 32 deletions, 0 additions. Co-authored-by: Cursor <cursoragent@cursor.com>
tamer-hassan-tether
pushed a commit
that referenced
this pull request
May 6, 2026
) The "Create and Upload Test Spec" step's run: | block in integration-mobile-test-qvac-lib-infer-llamacpp-llm.yml grew to 21,074 chars after #1889, putting it just over GitHub Actions' 21,000-char limit on a single template expression. This breaks every reusable-workflow_call into the file, so the On PR Trigger (LLM) workflow fails instantly with: error parsing called workflow ... : (Line: 914, Col: 14): Exceeded max expression length 21000 and no jobs run. Every open PR that touches the LLM package is currently blocked from getting LLM CI. Fix: remove 32 in-block comment lines that were pure narration of already-readable code (echo/printf/sed) and verbose intent text duplicated by the surrounding context. Brings the run-block payload to ~19,008 chars (well under 21,000) without changing any executed logic. Diff is comments-only: 32 deletions, 0 additions. Co-authored-by: Cursor <cursoragent@cursor.com>
Proletter
pushed a commit
that referenced
this pull request
May 24, 2026
* Create new buckets to run tests in independent processes. Signed-off-by: Marcus Edel <marcus.edel@collabora.com> * ci(ios): include all run ARNs in results aggregation and log download The two RUN_ARNS aggregation loops were hardcoded to iterate over indices 2..8, so the new Heavy7/Heavy8 runs (RUN_ARN_9, RUN_ARN_10) were silently dropped from the final test-results summary and the Device Farm log download. As a result, Heavy7/Heavy8 failures would not have failed the workflow and their device logs would not have been collected. Iterate up to RUN_COUNT instead, so any future bucket additions are picked up automatically. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Signed-off-by: Marcus Edel <marcus.edel@collabora.com> Co-authored-by: gianni-cor <gianfranco.cordella@tether.io> Co-authored-by: Cursor <cursoragent@cursor.com>
Proletter
pushed a commit
that referenced
this pull request
May 24, 2026
) The "Create and Upload Test Spec" step's run: | block in integration-mobile-test-qvac-lib-infer-llamacpp-llm.yml grew to 21,074 chars after #1889, putting it just over GitHub Actions' 21,000-char limit on a single template expression. This breaks every reusable-workflow_call into the file, so the On PR Trigger (LLM) workflow fails instantly with: error parsing called workflow ... : (Line: 914, Col: 14): Exceeded max expression length 21000 and no jobs run. Every open PR that touches the LLM package is currently blocked from getting LLM CI. Fix: remove 32 in-block comment lines that were pure narration of already-readable code (echo/printf/sed) and verbose intent text duplicated by the surrounding context. Brings the run-block payload to ~19,008 chars (well under 21,000) without changing any executed logic. Diff is comments-only: 32 deletions, 0 additions. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create new buckets to run tests in independent processes.