chore[qvac-lib-inference-addon-cpp]: drop unused project VERSION#1852
Merged
Conversation
… CMakeLists The version in CMakeLists.txt kept drifting from vcpkg.json (currently 1.1.4 vs 1.1.5) but was never consumed: no downstream package calls find_package(qvac-lib-inference-addon-cpp <version> ...) — they all use find_path() to locate headers. Remove the project VERSION and the generated ConfigVersion.cmake so vcpkg.json stays the single source of truth. Bump vcpkg.json version to 1.1.6, as it drifted from the version in the registry.
gianni-cor
approved these changes
May 1, 2026
dev-nid
approved these changes
May 1, 2026
Contributor
Author
|
/review |
Contributor
Tier-based Approval Status |
Merged
Proletter
pushed a commit
that referenced
this pull request
May 24, 2026
… CMakeLists (#1852) The version in CMakeLists.txt kept drifting from vcpkg.json (currently 1.1.4 vs 1.1.5) but was never consumed: no downstream package calls find_package(qvac-lib-inference-addon-cpp <version> ...) — they all use find_path() to locate headers. Remove the project VERSION and the generated ConfigVersion.cmake so vcpkg.json stays the single source of truth. Bump vcpkg.json version to 1.1.6, as it drifted from the version in the registry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What problem does this PR solve?
VERSIONinCMakeLists.txt(project(... VERSION 1.1.4 ...)) keeps drifting from the version invcpkg.json(currently1.1.5), creating two sources of truth for the package version.write_basic_package_version_file()to generateqvac-lib-inference-addon-cppConfigVersion.cmake, which is never consumed — no downstream package callsfind_package(qvac-lib-inference-addon-cpp <version> ...). All consumers (qvac-lib-infer-llamacpp-llm,-embed,-whispercpp,-nmtcpp,-parakeet,-onnx-tts,diffusion-cpp,bci-whispercpp,ocr-onnx) locate headers viafind_path(QVAC_LIB_INFERENCE_ADDON_CPP_INCLUDE_DIRS "qvac-lib-inference-addon-cpp/...hpp").📝 How does it solve it?
VERSION 1.1.4from theproject()call inCMakeLists.txt.write_basic_package_version_file()call and the install of the generatedqvac-lib-inference-addon-cppConfigVersion.cmake. TheConfig.cmake(without version) is still generated and installed for any futurefind_packageconsumers.vcpkg.jsonversion1.1.5 → 1.1.6so the cleanup ships as a new port version.vcpkg.jsonremains the single source of truth for the package version.🧪 How was it tested?
find_package(qvac-lib-inference-addon-cpp ...)call exists; all consumers usefind_pathfor header discovery."version>=": "1.1.x"in theirvcpkg.jsons and≥1.1.xmentions in CHANGELOGs/READMEs) target thevcpkg.jsonversion, which remains intact.