Skip to content

chore[qvac-lib-inference-addon-cpp]: drop unused project VERSION#1852

Merged
jpgaribotti merged 2 commits into
tetherto:mainfrom
jpgaribotti:addon-cpp-version
May 1, 2026
Merged

chore[qvac-lib-inference-addon-cpp]: drop unused project VERSION#1852
jpgaribotti merged 2 commits into
tetherto:mainfrom
jpgaribotti:addon-cpp-version

Conversation

@jpgaribotti

Copy link
Copy Markdown
Contributor

🎯 What problem does this PR solve?

  • The VERSION in CMakeLists.txt (project(... VERSION 1.1.4 ...)) keeps drifting from the version in vcpkg.json (currently 1.1.5), creating two sources of truth for the package version.
  • The CMake-side version is effectively dead code: it only feeds write_basic_package_version_file() to generate qvac-lib-inference-addon-cppConfigVersion.cmake, which is never consumed — no downstream package calls find_package(qvac-lib-inference-addon-cpp <version> ...). All consumers (qvac-lib-infer-llamacpp-llm, -embed, -whispercpp, -nmtcpp, -parakeet, -onnx-tts, diffusion-cpp, bci-whispercpp, ocr-onnx) locate headers via find_path(QVAC_LIB_INFERENCE_ADDON_CPP_INCLUDE_DIRS "qvac-lib-inference-addon-cpp/...hpp").

📝 How does it solve it?

  • Drop VERSION 1.1.4 from the project() call in CMakeLists.txt.
  • Drop the write_basic_package_version_file() call and the install of the generated qvac-lib-inference-addon-cppConfigVersion.cmake. The Config.cmake (without version) is still generated and installed for any future find_package consumers.
  • Bump vcpkg.json version 1.1.5 → 1.1.6 so the cleanup ships as a new port version. vcpkg.json remains the single source of truth for the package version.

🧪 How was it tested?

  • Verified via repo-wide grep that no find_package(qvac-lib-inference-addon-cpp ...) call exists; all consumers use find_path for header discovery.
  • All version constraints in dependent packages ("version>=": "1.1.x" in their vcpkg.jsons and ≥1.1.x mentions in CHANGELOGs/READMEs) target the vcpkg.json version, which remains intact.

… CMakeLists

The version in CMakeLists.txt kept drifting from vcpkg.json (currently
1.1.4 vs 1.1.5) but was never consumed: no downstream package calls
find_package(qvac-lib-inference-addon-cpp <version> ...) — they all use
find_path() to locate headers. Remove the project VERSION and the
generated ConfigVersion.cmake so vcpkg.json stays the single source of
truth.

Bump vcpkg.json version to 1.1.6, as it drifted from the version in the
registry.
@jpgaribotti jpgaribotti requested review from a team as code owners May 1, 2026 09:22
@jpgaribotti

Copy link
Copy Markdown
Contributor Author

/review

@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

Tier-based Approval Status

**PR Tier:** TIER1

**Current Status:** ✅ APPROVED

**Requirements:**
- 1 Team Member approval ✅ (1/1)
- 1 Team Lead OR Management approval ✅ (1/1)



---
*This comment is automatically updated when reviews change.*

@jpgaribotti jpgaribotti merged commit 7c6fe7c into tetherto:main May 1, 2026
6 checks passed
@mario-rei mario-rei mentioned this pull request May 1, 2026
@jpgaribotti jpgaribotti deleted the addon-cpp-version branch May 21, 2026 08:28
Proletter pushed a commit that referenced this pull request May 24, 2026
… CMakeLists (#1852)

The version in CMakeLists.txt kept drifting from vcpkg.json (currently
1.1.4 vs 1.1.5) but was never consumed: no downstream package calls
find_package(qvac-lib-inference-addon-cpp <version> ...) — they all use
find_path() to locate headers. Remove the project VERSION and the
generated ConfigVersion.cmake so vcpkg.json stays the single source of
truth.

Bump vcpkg.json version to 1.1.6, as it drifted from the version in the
registry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants