chore[notask]: backmerge release @qvac/cli v0.2.4#1766
Merged
simon-iribarren merged 4 commits intoApr 28, 2026
Conversation
opaninakuffo
approved these changes
Apr 27, 2026
NamelsKing
approved these changes
Apr 28, 2026
6 tasks
simon-iribarren
added a commit
that referenced
this pull request
Apr 28, 2026
…pe (#1775) PR #1596 (Apr 15) updated the CLI's `sdkEmbed` for the new SDK 0.9+ embed() return shape — it changed from raw `Promise<number[] | number[][]>` to wrapped `Promise<{ embedding, stats? }>`. The CLI's `sdkEmbed` destructures `{ embedding }` from the result, then the OpenAI embeddings route reads it as `embeddings[0]`. That PR landed the runtime change but did not bump the `@qvac/sdk` semver in `packages/cli/package.json`. It still requires `^0.8.0`, which in npm semver means `>=0.8.0 <0.9.0`. CI installs @qvac/sdk@0.8.0, whose `embed()` returns the raw vector array. The CLI then destructures `{ embedding }` from a number array, gets `undefined`, and the route handler crashes on `embeddings[0]`. The error is caught, the response becomes a 500 with `{ error: { code: 'embed_error' } }`, and the e2e tests asserting `.object == "list"` fail with no obvious hint as to why: not ok 40 embeddings: single input returns vector (e2e.bats:184) not ok 41 embeddings: batch input returns multiple vectors (e2e.bats:198) These two tests have been red on every CLI PR's CI since #1596 merged (visible on PR #1681, #1766, and others); chat and transcription tests are unaffected because their SDK contracts didn't change. Bump `@qvac/sdk` to `^0.9.0` so the lockfile picks up 0.9.x at install time, and bump the runtime `MIN_SDK_VERSION` constant to match. The SDK 0.9 series is published on npm (0.9.0 and 0.9.1 both available). Verified locally: rm -rf node_modules bun.lock && bun install resolves @qvac/sdk to 0.9.1; full e2e suite now passes the embeddings tests: ok 6 embeddings: single input returns vector ok 7 embeddings: batch input returns multiple vectors
Contributor
Author
|
/review |
Contributor
Tier-based Approval Status |
Contributor
Author
|
/review |
GustavoA1604
pushed a commit
that referenced
this pull request
Apr 29, 2026
…pe (#1775) PR #1596 (Apr 15) updated the CLI's `sdkEmbed` for the new SDK 0.9+ embed() return shape — it changed from raw `Promise<number[] | number[][]>` to wrapped `Promise<{ embedding, stats? }>`. The CLI's `sdkEmbed` destructures `{ embedding }` from the result, then the OpenAI embeddings route reads it as `embeddings[0]`. That PR landed the runtime change but did not bump the `@qvac/sdk` semver in `packages/cli/package.json`. It still requires `^0.8.0`, which in npm semver means `>=0.8.0 <0.9.0`. CI installs @qvac/sdk@0.8.0, whose `embed()` returns the raw vector array. The CLI then destructures `{ embedding }` from a number array, gets `undefined`, and the route handler crashes on `embeddings[0]`. The error is caught, the response becomes a 500 with `{ error: { code: 'embed_error' } }`, and the e2e tests asserting `.object == "list"` fail with no obvious hint as to why: not ok 40 embeddings: single input returns vector (e2e.bats:184) not ok 41 embeddings: batch input returns multiple vectors (e2e.bats:198) These two tests have been red on every CLI PR's CI since #1596 merged (visible on PR #1681, #1766, and others); chat and transcription tests are unaffected because their SDK contracts didn't change. Bump `@qvac/sdk` to `^0.9.0` so the lockfile picks up 0.9.x at install time, and bump the runtime `MIN_SDK_VERSION` constant to match. The SDK 0.9 series is published on npm (0.9.0 and 0.9.1 both available). Verified locally: rm -rf node_modules bun.lock && bun install resolves @qvac/sdk to 0.9.1; full e2e suite now passes the embeddings tests: ok 6 embeddings: single input returns vector ok 7 embeddings: batch input returns multiple vectors
GustavoA1604
pushed a commit
that referenced
this pull request
Apr 29, 2026
NamelsKing
added a commit
that referenced
this pull request
May 4, 2026
…angelog (#1867) Brings the @qvac/cli@0.3.0 release artifacts back onto main per gitflow.md "Keep main aligned". Same shape as #1766 (the 0.2.4 backmerge precedent). - packages/cli/package.json: version 0.2.4 -> 0.3.0 - packages/cli/changelog/0.3.0/CHANGELOG.md: new - packages/cli/changelog/0.3.0/api.md: new - packages/cli/CHANGELOG.md: prepend ## [0.3.0] entry NOTE: Opened as DRAFT because the companion release PR #1836 is also still draft and 5 of its CI checks are failing. @qvac/cli@0.3.0 has not yet been published to npm (latest is 0.2.4). Mark this PR ready for review only after #1836 merges into release-cli-0.3.0 and the GPR/npm publish completes. The source-level changes (@qvac/sdk devDep ^0.10.0 + sdk.ts MIN_SDK_VERSION='0.10.0') are already on main from PR #1810 — only the release metadata needs to come back. CLI's package.json on main has no dependency drift versus release-cli-0.3.0, so unlike the SDK 0.9.2 backmerge (#1857) the package.json version bump can be safely included here. There's also no competing CLI release PR in flight on main. Co-authored-by: Dmytro Medvinskyi <functionsilence@gmail.com>
tamer-hassan-tether
pushed a commit
that referenced
this pull request
May 5, 2026
…angelog (#1867) Brings the @qvac/cli@0.3.0 release artifacts back onto main per gitflow.md "Keep main aligned". Same shape as #1766 (the 0.2.4 backmerge precedent). - packages/cli/package.json: version 0.2.4 -> 0.3.0 - packages/cli/changelog/0.3.0/CHANGELOG.md: new - packages/cli/changelog/0.3.0/api.md: new - packages/cli/CHANGELOG.md: prepend ## [0.3.0] entry NOTE: Opened as DRAFT because the companion release PR #1836 is also still draft and 5 of its CI checks are failing. @qvac/cli@0.3.0 has not yet been published to npm (latest is 0.2.4). Mark this PR ready for review only after #1836 merges into release-cli-0.3.0 and the GPR/npm publish completes. The source-level changes (@qvac/sdk devDep ^0.10.0 + sdk.ts MIN_SDK_VERSION='0.10.0') are already on main from PR #1810 — only the release metadata needs to come back. CLI's package.json on main has no dependency drift versus release-cli-0.3.0, so unlike the SDK 0.9.2 backmerge (#1857) the package.json version bump can be safely included here. There's also no competing CLI release PR in flight on main. Co-authored-by: Dmytro Medvinskyi <functionsilence@gmail.com>
Proletter
pushed a commit
that referenced
this pull request
May 24, 2026
…pe (#1775) PR #1596 (Apr 15) updated the CLI's `sdkEmbed` for the new SDK 0.9+ embed() return shape — it changed from raw `Promise<number[] | number[][]>` to wrapped `Promise<{ embedding, stats? }>`. The CLI's `sdkEmbed` destructures `{ embedding }` from the result, then the OpenAI embeddings route reads it as `embeddings[0]`. That PR landed the runtime change but did not bump the `@qvac/sdk` semver in `packages/cli/package.json`. It still requires `^0.8.0`, which in npm semver means `>=0.8.0 <0.9.0`. CI installs @qvac/sdk@0.8.0, whose `embed()` returns the raw vector array. The CLI then destructures `{ embedding }` from a number array, gets `undefined`, and the route handler crashes on `embeddings[0]`. The error is caught, the response becomes a 500 with `{ error: { code: 'embed_error' } }`, and the e2e tests asserting `.object == "list"` fail with no obvious hint as to why: not ok 40 embeddings: single input returns vector (e2e.bats:184) not ok 41 embeddings: batch input returns multiple vectors (e2e.bats:198) These two tests have been red on every CLI PR's CI since #1596 merged (visible on PR #1681, #1766, and others); chat and transcription tests are unaffected because their SDK contracts didn't change. Bump `@qvac/sdk` to `^0.9.0` so the lockfile picks up 0.9.x at install time, and bump the runtime `MIN_SDK_VERSION` constant to match. The SDK 0.9 series is published on npm (0.9.0 and 0.9.1 both available). Verified locally: rm -rf node_modules bun.lock && bun install resolves @qvac/sdk to 0.9.1; full e2e suite now passes the embeddings tests: ok 6 embeddings: single input returns vector ok 7 embeddings: batch input returns multiple vectors
Proletter
pushed a commit
that referenced
this pull request
May 24, 2026
Proletter
pushed a commit
that referenced
this pull request
May 24, 2026
…pe (#1775) PR #1596 (Apr 15) updated the CLI's `sdkEmbed` for the new SDK 0.9+ embed() return shape — it changed from raw `Promise<number[] | number[][]>` to wrapped `Promise<{ embedding, stats? }>`. The CLI's `sdkEmbed` destructures `{ embedding }` from the result, then the OpenAI embeddings route reads it as `embeddings[0]`. That PR landed the runtime change but did not bump the `@qvac/sdk` semver in `packages/cli/package.json`. It still requires `^0.8.0`, which in npm semver means `>=0.8.0 <0.9.0`. CI installs @qvac/sdk@0.8.0, whose `embed()` returns the raw vector array. The CLI then destructures `{ embedding }` from a number array, gets `undefined`, and the route handler crashes on `embeddings[0]`. The error is caught, the response becomes a 500 with `{ error: { code: 'embed_error' } }`, and the e2e tests asserting `.object == "list"` fail with no obvious hint as to why: not ok 40 embeddings: single input returns vector (e2e.bats:184) not ok 41 embeddings: batch input returns multiple vectors (e2e.bats:198) These two tests have been red on every CLI PR's CI since #1596 merged (visible on PR #1681, #1766, and others); chat and transcription tests are unaffected because their SDK contracts didn't change. Bump `@qvac/sdk` to `^0.9.0` so the lockfile picks up 0.9.x at install time, and bump the runtime `MIN_SDK_VERSION` constant to match. The SDK 0.9 series is published on npm (0.9.0 and 0.9.1 both available). Verified locally: rm -rf node_modules bun.lock && bun install resolves @qvac/sdk to 0.9.1; full e2e suite now passes the embeddings tests: ok 6 embeddings: single input returns vector ok 7 embeddings: batch input returns multiple vectors
Proletter
pushed a commit
that referenced
this pull request
May 24, 2026
Proletter
pushed a commit
that referenced
this pull request
May 24, 2026
…angelog (#1867) Brings the @qvac/cli@0.3.0 release artifacts back onto main per gitflow.md "Keep main aligned". Same shape as #1766 (the 0.2.4 backmerge precedent). - packages/cli/package.json: version 0.2.4 -> 0.3.0 - packages/cli/changelog/0.3.0/CHANGELOG.md: new - packages/cli/changelog/0.3.0/api.md: new - packages/cli/CHANGELOG.md: prepend ## [0.3.0] entry NOTE: Opened as DRAFT because the companion release PR #1836 is also still draft and 5 of its CI checks are failing. @qvac/cli@0.3.0 has not yet been published to npm (latest is 0.2.4). Mark this PR ready for review only after #1836 merges into release-cli-0.3.0 and the GPR/npm publish completes. The source-level changes (@qvac/sdk devDep ^0.10.0 + sdk.ts MIN_SDK_VERSION='0.10.0') are already on main from PR #1810 — only the release metadata needs to come back. CLI's package.json on main has no dependency drift versus release-cli-0.3.0, so unlike the SDK 0.9.2 backmerge (#1857) the package.json version bump can be safely included here. There's also no competing CLI release PR in flight on main. Co-authored-by: Dmytro Medvinskyi <functionsilence@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backmerge of
release-cli-0.2.4intomainafter the @qvac/cli v0.2.4 release (#1752) was merged and GPR-published. Merging this PR triggers the npm publish for@qvac/cli@0.2.4.The only change vs
mainis the version bump and changelog committed in #1752:packages/cli/package.json:0.2.3→0.2.4packages/cli/CHANGELOG.md: add[0.2.4]entrypackages/cli/changelog/0.2.4/CHANGELOG.md: newReleased fixes
SDKModule.embedtype andsdkEmbed()to handle the new{ embedding, stats? }return shape introduced in@qvac/sdk0.9+. CLI's internalnumber[] | number[][]contract preserved. (PR #1596)node_modulespackages when generating the addons manifest inqvac bundle sdk, so deeply-hoisted addon dependencies are included in the mobile worker bundle. (PR #1731)Checklist
Related PRs