fix[notask]: extract nested node_modules packages in addons manifest …#1731
Merged
Conversation
e6c6b00 to
5f304c7
Compare
5f304c7 to
e1c87e4
Compare
simon-iribarren
approved these changes
Apr 24, 2026
simon-iribarren
left a comment
Contributor
There was a problem hiding this comment.
Approving.
Clear root-cause + fix:
.match()without/gon/node_modules/([^/]+)/-style paths only captures the first segment, so nested packages (/node_modules/@qvac/sdk/node_modules/bare-abort/...) were silently dropped. Switch tomatchAll()+/gis the right move.package.jsonlookup extended to nestednode_modulespaths so the resolver can actually find the addon manifests it needs.- 0 → 34 addons detected is a strong regression-class signal; the explicit regression test that asserts the old regex misses nested packages is exactly the shape of test I want to see for bugs like this.
CI: confirmed check (cli) failures on tests #40/#41 (embeddings: single input returns vector / batch input returns multiple vectors) are pre-existing — same two tests fail on unrelated PRs (e.g. #1681 at tests #42/#43; difference is just numbering due to skip counts). Not a blocker for this PR.
Contributor
Tier-based Approval Status |
NamelsKing
approved these changes
Apr 24, 2026
Contributor
Author
|
/review |
This was referenced Apr 27, 2026
Proletter
pushed a commit
that referenced
this pull request
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Mobile apps crash at runtime with
ADDON_NOT_FOUNDfor native addons (bare-abort,bare-os,bare-fs, etc.). The addons manifest always generates"addons": [], sobare-linknever creates the required xcframeworks/shared libraries.How does it solve it?
Bundle resolution keys contain nested paths like
/node_modules/@qvac/sdk/node_modules/bare-abort/binding.js. The regex used.match()without/g, capturing only the first segment (@qvac/sdk) and missing all nested addon packages. Additionally,package.jsonlookup only checked rootnode_modules/, missing nested packages./gflag withmatchAll()to capture allnode_modulessegments per resolution keypackage.jsonin both root and nestednode_modulespathsResult: 34 native addons detected vs 0 before.
How was it tested?
extractPackedString/extractBarePackHeaderhelpersADDON_NOT_FOUNDNote:
check (cli)e2e tests #40/#41 (embeddings) are a pre-existing failure — same tests fail on unrelated PRs (e.g. QVAC-12239).