Skip to content

fix[notask]: validate modelDir path in TTS benchmark server to prevent traversal #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sharmaraju352 merged 2 commits into from
Mar 24, 2026
Merged

fix[notask]: validate modelDir path in TTS benchmark server to prevent traversal #1103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
409e8d4
fix[notask]: validate modelDir path in TTS benchmark server to preven…
Mar 24, 2026
194f683
Merge branch 'main' into fix/tts-benchmark-modeldir-path-validation
sharmaraju352 Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/qvac-lib-infer-onnx-tts/benchmarks/server/src/services/runChatterboxTTS.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,11 @@ async function runChatterboxTTS (payload) {

logger.info(`[Chatterbox] Processing ${texts.length} texts`)

// Resolve paths relative to benchmarks directory if not absolute
let modelDir = config.modelDir || DEFAULT_MODEL_DIR
if (!path.isAbsolute(modelDir)) {
modelDir = path.join(BENCHMARKS_DIR, modelDir)
modelDir = path.isAbsolute(modelDir) ? modelDir : path.join(BENCHMARKS_DIR, modelDir)
modelDir = path.resolve(modelDir)
if (!modelDir.startsWith(BENCHMARKS_DIR) && !modelDir.startsWith(SHARED_DATA_DIR)) {
throw new Error('modelDir must be within the benchmarks or shared-data directory')
}

const tokenizerPath = path.join(modelDir, 'tokenizer.json')
Expand Down
6 changes: 4 additions & 2 deletions packages/qvac-lib-infer-onnx-tts/benchmarks/server/src/services/runSupertonicTTS.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,10 @@ async function runSupertonicTTS (payload) {
logger.info(`[Supertonic] Processing ${texts.length} texts`)

let modelDir = config.modelDir || DEFAULT_MODEL_DIR
if (!path.isAbsolute(modelDir)) {
modelDir = path.join(BENCHMARKS_DIR, modelDir)
modelDir = path.isAbsolute(modelDir) ? modelDir : path.join(BENCHMARKS_DIR, modelDir)
modelDir = path.resolve(modelDir)
if (!modelDir.startsWith(BENCHMARKS_DIR) && !modelDir.startsWith(SHARED_DATA_DIR)) {
throw new Error('modelDir must be within the benchmarks or shared-data directory')
}

const voiceName = config.voiceName || 'F1'
Expand Down
Loading