fix[notask]: validate modelDir path in TTS benchmark server to prevent traversal#1103
Merged
Merged
Conversation
…t traversal Both runChatterboxTTS and runSupertonicTTS accepted arbitrary absolute paths for modelDir, allowing directory enumeration outside the benchmark directory. Validate that resolved modelDir is within BENCHMARKS_DIR or SHARED_DATA_DIR before proceeding. Made-with: Cursor
ishanvohra2
approved these changes
Mar 24, 2026
Contributor
Tier-based Approval Status |
GustavoA1604
approved these changes
Mar 24, 2026
Contributor
Author
|
/review |
Proletter
pushed a commit
that referenced
this pull request
May 24, 2026
…t traversal (#1103) Both runChatterboxTTS and runSupertonicTTS accepted arbitrary absolute paths for modelDir, allowing directory enumeration outside the benchmark directory. Validate that resolved modelDir is within BENCHMARKS_DIR or SHARED_DATA_DIR before proceeding. Made-with: Cursor Co-authored-by: Raju <raju.sharma>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
modelDirresolves withinBENCHMARKS_DIRorSHARED_DATA_DIRin bothrunChatterboxTTSandrunSupertonicTTSto prevent directory traversalHow was it tested?
Made with Cursor