Conversation
…ve-ethash Remove ethash to make go-ethereum hive work
…_geth CI: Pin geth to v1.11.6
pcw109550
force-pushed
the
pcw109550/pin-geth
branch
from
a1726e8 to
ac6c980
Compare
ImTei
approved these changes
Jul 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mirrors ethereum-optimism#82.
The PR applies ethereum-optimism#81 again which was firstly merged to this repo at #7.
The reason to pin geth version to v1.11.6 is that geth release v1.12.0 introduced breaking changes, such as dropping proof-of-work.
Although using v1.12.0(the latest version) worked, upstream decided to pin to v1.11.6 for avoiding unintended hive test failure. This repo will follow this change, because we are not using geth v1.12.0 specific feature at the moment.
Base branch will be changed to
op-erigonwhenpcw109550/daisy-chain-testsis merged toop-erigon.