Remove ethash to make go-ethereum hive work#81
Merged
ajsutton merged 2 commits intoethereum-optimism:optimismfrom May 4, 2023
Merged
Remove ethash to make go-ethereum hive work#81ajsutton merged 2 commits intoethereum-optimism:optimismfrom
ajsutton merged 2 commits intoethereum-optimism:optimismfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hive CI is failing due to ethash removal in go-ethereum. See ethereum/go-ethereum#27178.
Fix L1 go-ethereum hive docker init by removing ethash verification cache at Dockerfile and also
miner.threadsflag in entrypoint.Tests
This PR mirrors testinprod-io#7. CI passing again!
Additional context
This fix may also needed to https://github.com/ethereum/hive.