-
-
Notifications
You must be signed in to change notification settings - Fork 587
chore(dynamodb): use Run function #3406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary by CodeRabbit
WalkthroughRefactors the DynamoDB module to use testcontainers.Run with ContainerCustomizer helpers instead of GenericContainerRequest. Updates option handling to WithEntrypoint, WithCmdArgs, WithExposedPorts, WithWait, and WithReuseByName. Adjusts error messages and reworks WithSharedDB and WithDisableTelemetry to return composed customizers. Changes
Sequence Diagram(s)sequenceDiagram
participant U as Caller
participant D as DynamoDB Module
participant T as testcontainers.Run
participant C as Container
U->>D: New DynamoDB(...)
D->>D: Build moduleOpts<br/>- WithEntrypoint<br/>- WithCmdArgs<br/>- WithExposedPorts<br/>- WithWait
alt Shared DB enabled
D->>D: WithSharedDB<br/>- WithCmdArgs<br/>- WithReuseByName
end
opt Disable telemetry
D->>D: WithDisableTelemetry -> WithCmdArgs(-disableTelemetry)
end
D->>T: Run(ctx, image, moduleOpts...)
T-->>D: Container or error
D-->>U: Container handle or error
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧬 Code graph analysis (1)modules/dynamodb/dynamodb.go (2)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
What does this PR do?
Use Run function in the DynamoDB module
Why is it important?
Migrate modules to the new API
Related issues