-
-
Notifications
You must be signed in to change notification settings - Fork 588
chore(couchbase): use Run function #3401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary by CodeRabbit
WalkthroughRefactors Couchbase module to replace anonymous embedding of testcontainers.Container with a named Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Caller
participant CouchbaseModule
participant Testcontainers
Caller->>CouchbaseModule: Run(ctx, opts...)
CouchbaseModule->>CouchbaseModule: build moduleOpts (WithExposedPorts, env, wait, service customizers)
CouchbaseModule->>Testcontainers: Run(ctx, moduleOpts + opts)
alt success
Testcontainers-->>CouchbaseModule: container (ctr)
CouchbaseModule->>CouchbaseModule: CouchbaseContainer.Container = ctr
CouchbaseModule-->>Caller: CouchbaseContainer
else failure
Testcontainers-->>CouchbaseModule: err
CouchbaseModule-->>Caller: fmt.Errorf("run couchbase: %w", err)
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧬 Code graph analysis (1)modules/couchbase/couchbase.go (2)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
modules/couchbase/couchbase.go(2 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
modules/couchbase/couchbase.go (2)
options.go (2)
ContainerCustomizer(22-24)WithExposedPorts(454-459)modules/consul/consul.go (1)
Run(61-83)
What does this PR do?
Use Run function in the Couchbase module
Why is it important?
Migrate modules to the new API
Related issues