feat: add toxiproxy module #3092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
added
the
feature
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdelapenya
commented
Apr 8, 2025
mdelapenya
commented
Apr 8, 2025
mdelapenya
commented
Apr 8, 2025
eddumelendez
reviewed
Apr 8, 2025
Member
Author
|
@eddumelendez I added the ability to add proxies and generate the config on the fly. Could you PTAL? |
* main: security(compose): upgrade github.com/docker/compose/v2 to fix security vulnerability (testcontainers#3095) feat: add more functional options to the modules API (testcontainers#3070)
* main: chore(deps): bump golang.org/x/crypto in /modules/aerospike (testcontainers#3105) chore(ci): run codeql on the modified modules (testcontainers#3103) docs: fix reference to container types in Run function (testcontainers#3102) chore(deps): bump github.com/golang-jwt/jwt/v5 in /modules/pulsar (testcontainers#3101) chore(pulsar): bump github.com/apache/pulsar-client-go from 0.10.0 to 0.14.0 (testcontainers#3100) chore(clickhouse): bump github.com/ClickHouse/clickhouse-go/v2 from 2.20.0 to 2.34.0 in /modules/clickhouse (testcontainers#3099) chore(deps): bump github/codeql-action from 3.28.13 to 3.28.15 (testcontainers#3097) chore(deps): bump golang.org/x/crypto from 0.31.0 to 0.37.0 (testcontainers#3098) feat(aerospike): add Aerospike module (testcontainers#3094)
eddumelendez
previously approved these changes
Apr 17, 2025
stevenh
requested changes
Apr 17, 2025
Contributor
stevenh
left a comment
stevenh
left a comment
There was a problem hiding this comment.
A quick pass with some idiomatic go suggestions.
Member
Author
|
@stevenh comments addressed. Thank you for your thorough review 🙇 |
* main: chore(deps): bump golang.org/x/net from 0.36.0 to 0.38.0 in /modules and /examples (testcontainers#3114)
Member
Author
|
I'm merging this. Let's open an issue if we have last minute questions on it, thanks! |
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Apr 23, 2025
* main: feat: add toxiproxy module (testcontainers#3092)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Apr 23, 2025
* main: feat: add toxiproxy module (testcontainers#3092)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Apr 23, 2025
* main: feat: add toxiproxy module (testcontainers#3092) chore(ci): run core tests on Testcontainers Cloud (testcontainers#3117)
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Apr 24, 2025
* main: feat(redis): add TLS support (testcontainers#3115) feat: add Docker Model Runner module (testcontainers#3106) feat: add toxiproxy module (testcontainers#3092) chore(ci): run core tests on Testcontainers Cloud (testcontainers#3117) deps(aerospike): replace core module in go.mod (testcontainers#3116) chore(deps): bump golang.org/x/net from 0.36.0 to 0.38.0 in /modules and /examples (testcontainers#3114) chore(ci): revert codeql improvements for CI resiliency (testcontainers#3112) docs(socat): add missing version marker for new options (testcontainers#3111)
mdelapenya
added a commit
to xBlaz3kx/testcontainers-go
that referenced
this pull request
Apr 24, 2025
* main: feat(postgres): add WithOrderedInitScripts for Postgres testcontainers (testcontainers#3121) feat(redis): add TLS support (testcontainers#3115) feat: add Docker Model Runner module (testcontainers#3106) feat: add toxiproxy module (testcontainers#3092) chore(ci): run core tests on Testcontainers Cloud (testcontainers#3117) deps(aerospike): replace core module in go.mod (testcontainers#3116) chore(deps): bump golang.org/x/net from 0.36.0 to 0.38.0 in /modules and /examples (testcontainers#3114) chore(ci): revert codeql improvements for CI resiliency (testcontainers#3112) docs(socat): add missing version marker for new options (testcontainers#3111) deps: use pinned dependencies on GH actions (testcontainers#3110) chore(deps): bump jinja2 from 3.1.5 to 3.1.6 (testcontainers#3109) chore(ci): reduce GH runners usage by calling codeql in the lint stage (testcontainers#3108) deps(ci): use python 3.13 on Netlify deployments (testcontainers#3107)
mdelapenya
added a commit
to jm96441n/testcontainers-go
that referenced
this pull request
Apr 24, 2025
* main: feat(postgres): add WithOrderedInitScripts for Postgres testcontainers (testcontainers#3121) feat(redis): add TLS support (testcontainers#3115) feat: add Docker Model Runner module (testcontainers#3106) feat: add toxiproxy module (testcontainers#3092) chore(ci): run core tests on Testcontainers Cloud (testcontainers#3117) deps(aerospike): replace core module in go.mod (testcontainers#3116) chore(deps): bump golang.org/x/net from 0.36.0 to 0.38.0 in /modules and /examples (testcontainers#3114) chore(ci): revert codeql improvements for CI resiliency (testcontainers#3112) docs(socat): add missing version marker for new options (testcontainers#3111)
mdelapenya
added a commit
to georgespalding/testcontainers-go
that referenced
this pull request
Apr 25, 2025
* main: feat(postgres): add WithOrderedInitScripts for Postgres testcontainers (testcontainers#3121) feat(redis): add TLS support (testcontainers#3115) feat: add Docker Model Runner module (testcontainers#3106) feat: add toxiproxy module (testcontainers#3092) chore(ci): run core tests on Testcontainers Cloud (testcontainers#3117) deps(aerospike): replace core module in go.mod (testcontainers#3116)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR converts the existing example into a tc-go module.
It adds a functional option to modify the number of exposed ports in the range used by toxiproxy to add proxies.
This PR, intentionally, does not couple the implementation of the module with any toxiproxy Go client. On the other hand,
it uses
github.com/Shopify/toxiproxy/v2for the tests and examples.Finally, it removes the existing example module, converting that code into the testable examples of the new module.
Why is it important?
More modules!