-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop_query_vec #24
drop_query_vec #24
Conversation
Verified that it copies the pointer not the value.
|
qcols = {group[k].iloc[0] for k in group if group[k].nunique() == 1} I wonder if this is something that DataFrameBuilder could support directly somehow. (Or perhaps the use case is too niche.) |
@cmacdonald do the implementations so far meet your needs? |
LGTM |
The "adhoc rule" is that query columns (i.e. which should be common across a query) begin with a q. There are some methods for detecting query columns (no these dont seem to implement the rule, per se): Other pieces of code have weird joins, e.g. https://github.com/terrier-org/pyterrier/blob/master/pyterrier/terrier/retriever.py#L440-L441 - at least some used pt.model.query_columnms: https://github.com/search?q=repo%3Aterrier-org%2Fpyterrier%20pt.model.query_columns&type=code |
I'd be tempted to merge this for now. |
I'd rather be able to sort it completely instead of leaving it half-done. Implementations for the remaining ones are in progress. |
fixes #23
WIP: