Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retrievers consume the query_vec #23

Closed
cmacdonald opened this issue Nov 22, 2024 · 2 comments · Fixed by #24
Closed

retrievers consume the query_vec #23

cmacdonald opened this issue Nov 22, 2024 · 2 comments · Fixed by #24

Comments

@cmacdonald
Copy link
Collaborator

cmacdonald commented Nov 22, 2024

Returning query_vec is useful for PRF. Is this enough of a use case to make it the default?

@seanmacavaney
Copy link
Collaborator

I worry about duplicating the vectors in memory k times per query --- we'll need to be careful with this implementation to make sure this doesn't happen (especially if the default).

@cmacdonald
Copy link
Collaborator Author

aiui, its k pointers, rather than k tensors, but we can check this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants