Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ToggleButton and ToggleGroup #3739

Merged
merged 12 commits into from
Feb 16, 2024
Merged

Conversation

dnlkoch
Copy link
Member

@dnlkoch dnlkoch commented Feb 16, 2024

Description

This simplifies the internal handling of the ToggleButton and ToggleGroup components and corresponding buttons.

In addition:

  • update several dependencies
  • updates node in the workflows
  • refactors the Legend and LayerSwitcher components to function components

Replacement of #3509.

Please review @terrestris/devs.

Related issues or pull requests

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    BSD-2-Clause.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the Code of Conduct.
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

@dnlkoch dnlkoch marked this pull request as ready for review February 16, 2024 13:37
@dnlkoch dnlkoch merged commit a6db271 into rg-future Feb 16, 2024
2 checks passed
@dnlkoch dnlkoch deleted the refactor-toggle-button-updated branch February 16, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants