Refactor ToggleButton and ToggleGroup
#3509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Removes the deprecated DigitizeButton in favour of the DrawButton
Remove the deprecated `DigitizeButton` in favour of the `DrawButton`
BREAKING CHANGE: mappify, loadify, isVisibleComponent HOCs as well as MapProvider class were removed
Remove some deprecated HOCs
Dependency updates
BREAKING CHANGE: Panel, Window and Titlebar components are not existing anymore
Remove Window, Panel and Titlebar component
refactor: remove toolbar component
refactor: remove userchip component
Eslint: homogenize / sort imports using simple-sort-plugin
simonseyock
approved these changes
Sep 12, 2023
| if (onClick) { | ||
| onClick(evt); | ||
|
|
||
| if (evt.defaultPrevented) { |
There was a problem hiding this comment.
Why is this preventing onChange but not onClick?
There was a problem hiding this comment.
And why is it preventing onChange only if onClick is set?
There was a problem hiding this comment.
This might be a refactor-artifact. Will double check, but I assume it can be removed.
dnlkoch
force-pushed
the
refactor-toggle-button
branch
from
146986f
to
31fcc9f
Compare
dnlkoch
force-pushed
the
refactor-toggle-button
branch
2 times, most recently
from
728ec8f
to
7ddba57
Compare
BREAKING CHANGE: the AddWmsLayerEntry accepts a map prop now (required for attributions)
Update dependencies (`rg-future`)
BREAKING CHANGE: use geolocation hook of react-util
chore: refactor geolocation button
BREAKING CHANGE: The pressed state of the ToggleButton is controlled now
dnlkoch
force-pushed
the
refactor-toggle-button
branch
from
7ddba57
to
96d58ed
Compare
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This simplifies the internal handling of the
ToggleButtonandToggleGroupcomponents.TODOs:
GeolocationButtonandMeasureButtonaren't implementing the needed control of the pressed state, this will be done after they have been transformed to functional components (in a follow up PR)GeolocationButton✔️MeasureButton✔️the tests are still failing and need to be adjusted (in this PR)✔️there are some linting errors left (in this PR)✔️Please review @terrestris/devs.
Related issues or pull requests
--
Pull request type
Do you introduce a breaking change?
Checklist
BSD-2-Clause.
npm testlocally).