Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor geolocation button #3512

Merged
merged 2 commits into from
Oct 27, 2023
Merged

chore: refactor geolocation button #3512

merged 2 commits into from
Oct 27, 2023

Conversation

ahennr
Copy link
Member

@ahennr ahennr commented Sep 12, 2023

BREAKING CHANGE: use geolocation hook of react-util

Description

Related issues or pull requests

Requires #3596 (:white_check_mark:).

Pull request type

  • Bugfix
  • Feature
  • Dependency updates
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe)

Do you introduce a breaking change?

  • Yes
  • No

Checklist

  • I understand and agree that the changes in this PR will be licensed under the
    BSD-2-Clause.
  • I have followed the guidelines for contributing.
  • The proposed change fits to the content of the Code of Conduct.
  • I have added or updated tests and documentation, and the test suite passes (run npm test locally).
  • I have added a screenshot/screencast to illustrate the visual output of my update.

BREAKING CHANGE: use geolocation hook of react-util
@dnlkoch
Copy link
Member

dnlkoch commented Oct 27, 2023

Thanks for the review!

@dnlkoch dnlkoch merged commit f3f0953 into rg-future Oct 27, 2023
2 checks passed
@dnlkoch dnlkoch deleted the geolocation branch October 27, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants