images: replacing the dependency on acceptance.AzureProvider
#10519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is easier to refactor
This is tested within the `azurerm_image` resource, so no need to test this twice
This is to try and work around an eventual consistency issue I can see exists (via failing tests), but I'm struggling to repro: > compute.GalleryImagesClient#Delete: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=<nil> Code="CannotDeleteResource" Message="Can not delete resource before nested resources are deleted."
tombuildsstuff
added a commit
that referenced
this pull request
Feb 10, 2021
This commit enables the feature toggle for Binary Testing - which switches to using the real Terraform Binary when running Acceptance Tests and allows for different versions of Core to be used. Due to the use of Service Packages, we require that Reattach testing is used - as such this requires using Terraform Core 0.12.26 or later. This commit depends on - and must be rebased on top of - #10521 and #10519 due to the removal of `acceptance.AzureProvider` when Binary Testing is being used. A future commit will remove support for the legacy testing framework after a suitable transition period, but for the moment disabling this functionality is sufficient.
jackofallops
approved these changes
Feb 10, 2021
|
Tests for this look good 👍 |
tombuildsstuff
added a commit
that referenced
this pull request
Feb 10, 2021
tombuildsstuff
added a commit
that referenced
this pull request
Feb 10, 2021
This commit enables the feature toggle for Binary Testing - which switches to using the real Terraform Binary when running Acceptance Tests and allows for different versions of Core to be used. Due to the use of Service Packages, we require that Reattach testing is used - as such this requires using Terraform Core 0.12.26 or later. This commit depends on - and must be rebased on top of - #10521 and #10519 due to the removal of `acceptance.AzureProvider` when Binary Testing is being used. A future commit will remove support for the legacy testing framework after a suitable transition period, but for the moment disabling this functionality is sufficient.
tombuildsstuff
added a commit
that referenced
this pull request
Feb 11, 2021
This commit enables the feature toggle for Binary Testing - which switches to using the real Terraform Binary when running Acceptance Tests and allows for different versions of Core to be used. Due to the use of Service Packages, we require that Reattach testing is used - as such this requires using Terraform Core 0.12.26 or later. This commit depends on - and must be rebased on top of - #10521 and #10519 due to the removal of `acceptance.AzureProvider` when Binary Testing is being used. A future commit will remove support for the legacy testing framework after a suitable transition period, but for the moment disabling this functionality is sufficient.
|
This has been released in version 2.47.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.47.0"
}
# ... other configuration ... |
tombuildsstuff
added a commit
that referenced
this pull request
Feb 23, 2021
This commit enables the feature toggle for Binary Testing - which switches to using the real Terraform Binary when running Acceptance Tests and allows for different versions of Core to be used. Due to the use of Service Packages, we require that Reattach testing is used - as such this requires using Terraform Core 0.12.26 or later. This commit depends on - and must be rebased on top of - #10521 and #10519 due to the removal of `acceptance.AzureProvider` when Binary Testing is being used. A future commit will remove support for the legacy testing framework after a suitable transition period, but for the moment disabling this functionality is sufficient.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, this PR's complicated due to how tangled this was - in short this removes the dependency on
acceptance.AzureProviderby switching these to use Check functions. As a side effect this also fixes #10374 and fixes #10516 by switching to use ListComplete and iterating on the list, rather than only iterating over the first page of the Shared Image Versions.When this is merged, we can merge #10511 and then proceed with enabling Binary Testing.