Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: groundwork for Binary Testing #10511

Merged
merged 3 commits into from
Feb 10, 2021

Conversation

tombuildsstuff
Copy link
Contributor

This PR adds the necessary groundwork for Binary Testing to work in a feature-toggled manner. There's a few components necessary for this to work:

  1. Removing the remaining dependencies on acceptance.AzureProvider (in flight)
  2. Upgrading the Plugin SDK to use v1.16.0
  3. Turning on the feature toggle

As such whilst this work isn't immediately usable, after rebasing this on top of the changes from 1, including 2 and turning on 3 - both Binary Testing and the current testing framework both work.

Note to reviewers: the features block defined below is intentionally using the default feature-set - since the Exists functions within the test framework don't (and shouldn't) make use of them (but they are available during Terraform runtime)

This makes this easier to consume within TF, since we embed the version of
TF within the Provider user agent.
@tombuildsstuff tombuildsstuff added this to the v2.47.0 milestone Feb 9, 2021
@tombuildsstuff tombuildsstuff requested a review from a team February 9, 2021 12:37
@ghost ghost added the size/L label Feb 9, 2021
Copy link
Member

@jackofallops jackofallops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tombuildsstuff - LGTM 👍

@tombuildsstuff tombuildsstuff merged commit adf75b8 into master Feb 10, 2021
@tombuildsstuff tombuildsstuff deleted the f/binary-testing-groundwork branch February 10, 2021 13:56
@ghost
Copy link

ghost commented Feb 11, 2021

This has been released in version 2.47.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.47.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Mar 12, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants