Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

images: replacing the dependency on acceptance.AzureProvider #10519

Merged
merged 16 commits into from
Feb 10, 2021
Merged

images: replacing the dependency on acceptance.AzureProvider #10519

merged 16 commits into from
Feb 10, 2021

Commits on Feb 9, 2021

  1. testing: refactoring the ssh helpers out to their own testing package

    @tombuildsstuff
    tombuildsstuff committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    74f1917 View commit details
    Browse the repository at this point in the history

  2. r/image: refactoring the tests to use a template which should make th… 

    …is easier to refactor
    @tombuildsstuff
    tombuildsstuff committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    a645a85 View commit details
    Browse the repository at this point in the history

  3. refactor: removing the dependency on testCheckAzureVMExists

    @tombuildsstuff
    tombuildsstuff committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    54c12b8 View commit details
    Browse the repository at this point in the history

  4. refactor: removing the dependency on testCheckAzureVMSSExists

    @tombuildsstuff
    tombuildsstuff committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    3f25766 View commit details
    Browse the repository at this point in the history

  5. r/virtual_machine_scale_set: removing a duplicate test 

    This is tested within the `azurerm_image` resource, so no need to test this twice
    @tombuildsstuff
    tombuildsstuff committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    1bede1f View commit details
    Browse the repository at this point in the history

  6. compute: refactoring to use the new generalize image function

    @tombuildsstuff
    tombuildsstuff committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    db52ee5 View commit details
    Browse the repository at this point in the history

  7. ssh: retrying until the vm becomes available

    @tombuildsstuff
    tombuildsstuff committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    ffd8cb4 View commit details
    Browse the repository at this point in the history

  8. TestAccImage_customImageFromVMWithManagedDisks: fixing config

    @tombuildsstuff
    tombuildsstuff committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    9f4def5 View commit details
    Browse the repository at this point in the history

  9. ssh: a retry func is sufficient

    @tombuildsstuff
    tombuildsstuff committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    b73b0fa View commit details
    Browse the repository at this point in the history

  10. image: fixing tests

    @tombuildsstuff
    tombuildsstuff committed Feb 9, 2021
    Configuration menu
    Copy the full SHA
    d3b4189 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2021

  1. refactor: fixing the error messages for image

    @tombuildsstuff
    tombuildsstuff committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    782a5c9 View commit details
    Browse the repository at this point in the history

  2. d/shared_image_versions: switching to use ListComplete rather than ju… 

    …st the first page

Fixes #10374
Fixes #10516
    @tombuildsstuff
    tombuildsstuff committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    c62c3d0 View commit details
    Browse the repository at this point in the history

  3. r/shared_image_version: polling until the image has disappeared 

    This is to try and work around an eventual consistency issue I can see exists
(via failing tests), but I'm struggling to repro:

> compute.GalleryImagesClient#Delete: Failure sending request: StatusCode=0 -- Original Error: autorest/azure: Service returned an error. Status=<nil> Code="CannotDeleteResource" Message="Can not delete resource before nested resources are deleted."
    @tombuildsstuff
    tombuildsstuff committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    16ac10f View commit details
    Browse the repository at this point in the history

  4. image: ubuntu 18 -> 16 for tests

    @tombuildsstuff
    tombuildsstuff committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    350f701 View commit details
    Browse the repository at this point in the history

  5. image: fixing the TestAccDataSourceSharedImageVersions_ tests

    @tombuildsstuff
    tombuildsstuff committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    8cfd5ba View commit details
    Browse the repository at this point in the history

  6. images: fixing tests/lintin

    @tombuildsstuff
    tombuildsstuff committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    5bb929d View commit details
    Browse the repository at this point in the history