Add support for Terraform v0.12 #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aaron-lane Could you kindly rebase this against |
|
@Jberlinsky rebase in progress! |
aaron-lane
force-pushed
the
aaron-lane-0.12
branch
from
eb2e02e to
eb0a0e7
Compare
Heredocs break terraform_docs.sh
Co-Authored-By: Aaron Lane <[email protected]>
…implify-ci-pipeline Simplify test process by removing intermediary image build step
This patch fixes the check_terraform failure caused by the absence of the symlinked terraform.tfvars. The alternative to this would be to remove the symlinks.
dynamic can not be used as guest_accelerator is an attribute as a block. https://www.terraform.io/docs/configuration/attr-as-blocks.html
This appears to have changed from Terraform 0.11 which must have silently swallowed the out of bounds error.
aaron-lane
requested review from
adrienthebo,
Jberlinsky and
morgante
as code owners
Jberlinsky
reviewed
Jul 11, 2019
aaron-lane
force-pushed
the
aaron-lane-0.12
branch
from
6cc0bf8 to
a807f21
Compare
morgante
reviewed
Jul 12, 2019
| } | ||
| } | ||
|
|
||
| addons_config { | ||
| http_load_balancing { | ||
| disabled = "${var.http_load_balancing ? 0 : 1}" | ||
| disabled = ! var.http_load_balancing |
There was a problem hiding this comment.
Not sure I love this approach but it's okay.
morgante
approved these changes
Jul 12, 2019
aaron-lane
added a commit
that referenced
this pull request
Jul 12, 2019
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…-modules/aaron-lane-0.12 Add support for Terraform v0.12
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.