Simplify test process by removing intermediary image build step #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jberlinsky
requested review from
aaron-lane,
adrienthebo and
morgante
as code owners
aaron-lane
suggested changes
Jul 10, 2019
Co-Authored-By: Aaron Lane <[email protected]>
|
The tests ran using the 2.1.0 Docker image which is what we wanted to see. Merging to the release branch to enable further debugging. |
CPL-markus
pushed a commit
to WALTER-GROUP/terraform-google-kubernetes-engine
that referenced
this pull request
Jul 15, 2024
…-modules/internal/0.12-simplify-ci-pipeline Simplify test process by removing intermediary image build step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GoogleCloudPlatform/cloud-foundation-toolkit#217, we move
ca-certificatesandkubectlinstallation into the upstream Docker image, allowing us to remove these customizations from this module. This simplifies the CI pipeline (see GoogleCloudPlatform/cloud-foundation-toolkit#218), eliminating a moving part that is not present in most other modules in this organization.This PR is blocked on the merging of GoogleCloudPlatform/cloud-foundation-toolkit#217.