Conditional creation of cluster and related resources #7
Conversation
|
@antonbabenko can you please review? |
main.tf
Outdated
| @@ -83,15 +84,13 @@ data "aws_iam_policy_document" "monitoring_rds_assume_role" { | |||
| } | |||
|
|
|||
| resource "aws_iam_role" "rds_enhanced_monitoring" { | |||
| count = "${var.monitoring_interval > 0 ? 1 : 0}" | |||
|
|
|||
| count = "${var.create_resources ? var.monitoring_interval > 0 ? 1 : 0 : 0}" | |||
There was a problem hiding this comment.
Less comparisons is nicer, I believe:
| count = "${var.create_resources ? var.monitoring_interval > 0 ? 1 : 0 : 0}" | |
| count = "${var.create_resources && var.monitoring_interval > 0 ? 1 : 0}" |
main.tf
Outdated
| @@ -129,6 +128,7 @@ resource "aws_appautoscaling_policy" "autoscaling_read_replica_count" { | |||
| } | |||
|
|
|||
| resource "aws_security_group" "this" { | |||
| count = "${var.create_resources}" | |||
There was a problem hiding this comment.
Lets keep empty lines after count and always have it as the first one because this is meta-argument.
main.tf
Outdated
| @@ -137,8 +137,7 @@ resource "aws_security_group" "this" { | |||
| } | |||
|
|
|||
| resource "aws_security_group_rule" "default_ingress" { | |||
| count = "${length(var.allowed_security_groups)}" | |||
|
|
|||
| count = "${var.create_resources ? length(var.allowed_security_groups) : 0}" | |||
There was a problem hiding this comment.
Same here. New line is missing.
|
Hi there! @max-rocket-internet, I'm wondering why this feature wasn't delivered? |
|
Hi @igat64, sorry I can't remember exactly. Perhaps because the review process was going too slowly. Here's our copy of the module, the original version of the module here: https://github.com/deliveryhero/tf-aws-rds-aurora |
|
Ok, thank you @max-rocket-internet ! |
…eam-master [HARRI-136652]: Sync the upstream plus the custom changes
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Adding
create_resourcesto allow declaring the module without creating any resources. This is mentioned in #2