Few suggestions to improve

[antonbabenko]

Remaining things to fix before big announcements on the registry:

• Add all outputs for all resources (get names from official documentation for each resource))
• Review all variables for all resources (get names from official documentation for each resource)). Also copy defaults which are in the official documentation.
• Make examples executable, add README there, add outputs. And run them all.

After the release (any time later):

• Review the code. It should be possible to create several RDS clusters with the same name, so use name_prefix or synonyms on all resources.
• Add conditional creation of optional resources (security group, db subnet group can be provided externally).
• Add conditional creation of RDS cluster also.

[max-rocket-internet]

Add conditional creation of RDS cluster also.

How does that work? Without the cluster, there's no point in using the module?

[FutureSharks]

To the rest though, sounds good. I'll work on these in the coming weeks.

[antonbabenko]

It is not possible to disable module conditionally in Terraform. Check this out -
https://github.com/terraform-aws-modules/terraform-aws-vpc#conditional-creation

Users may want to enable/disable creation of RDS clusters using the same code, so that they need to have a boolean flag create_cluster = true.

[FutureSharks]

Users may want to enable/disable creation of RDS clusters using the same code

OK gotcha 👍

[bryantbiggs]

I believe most (if not all) are complete so closing out

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.