Skip to content

fix: Add validate_certificate variable in atlantis module #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix: Add validate_certificate variable in atlantis module #361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5316ffe
fix: validate_certificate
bakayolo Oct 2, 2023
f828d48
fix: pre-commit deps
bakayolo Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ resource "aws_ssm_parameter" "atlantis_github_app_key" {

module "vpc" {
source = "terraform-aws-modules/vpc/aws"
version = "v3.6.0"
version = "v3.19.0"

create_vpc = var.vpc_id == ""

Expand Down Expand Up @@ -416,7 +416,8 @@ module "acm" {
source = "terraform-aws-modules/acm/aws"
version = "v3.2.0"

create_certificate = var.certificate_arn == ""
create_certificate = var.certificate_arn == ""
validate_certificate = var.validate_certificate

domain_name = var.acm_certificate_domain_name == "" ? join(".", [var.name, var.route53_zone_name]) : var.acm_certificate_domain_name

Expand Down Expand Up @@ -507,7 +508,7 @@ resource "aws_efs_access_point" "this" {
################################################################################
module "ecs" {
source = "terraform-aws-modules/ecs/aws"
version = "v3.3.0"
version = "v3.5.0"

create_ecs = var.create_ecs_cluster

Expand Down Expand Up @@ -590,7 +591,7 @@ data "aws_iam_policy_document" "ecs_task_access_secrets" {
data "aws_iam_policy_document" "ecs_task_access_secrets_with_kms" {
count = var.ssm_kms_key_arn == "" ? 0 : 1

source_json = data.aws_iam_policy_document.ecs_task_access_secrets.json
source_policy_documents = [ data.aws_iam_policy_document.ecs_task_access_secrets.json ]

statement {
sid = "AllowKMSDecrypt"
Expand Down
6 changes: 6 additions & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,12 @@ variable "certificate_arn" {
default = ""
}

variable "validate_certificate" {
description = "Whether to validate certificate by creating Route53 record"
type = bool
default = true
}

variable "acm_certificate_domain_name" {
description = "Route53 domain name to use for ACM certificate. Route53 zone for this domain should be created in advance. Specify if it is different from value in `route53_zone_name`"
type = string
Expand Down