fix: Add validate_certificate variable in atlantis module

[bakayolo]

Description

Add the option to set the validate_certificate variable as part of the acm module. This variable will trigger the creation of a route53 record to validate the certificate ownership.

Allowing to disable this variable is useful when using external DNS (not route53).

Motivation and Context

Fixes #360

I decided to add a new variable, and not set validate_certificate = var.create_route53_record || var.create_route53_aaaa_record to not introduce a breaking change.

Breaking Changes

This is not a breaking change.
The value added is default to true in the acm module, and I defaulted to true in the atlantis module.

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects

• I have executed pre-commit run -a on my pull request
• I have tested and validated these changes using my own deployment

[antonbabenko]

Please update the rest to make CI checks green.

[bakayolo]

@antonbabenko the ECS error disappear when bumping the module to the latest version. However, for the vpc module, I would need to bump the major version because of enable_classiclink and enable_classiclink_dns_support not supported by aws anymore.

And this module has a breaking change

• The minimum required Terraform version is now 1.0
• The minimum required AWS provider version is now 4.x (4.35.0 at time of writing)
• assign_ipv6_address_on_creation has been removed; use the respective subnet type equivalent instead (i.e. - public_subnet_assign_ipv6_address_on_creation)
• enable_classiclink has been removed; it is no longer supported by AWS Subtle issue representing null as unset value, resulting in deprecation warning hashicorp/terraform#31730
• enable_classiclink_dns_support has been removed; it is no longer supported by AWS Subtle issue representing null as unset value, resulting in deprecation warning hashicorp/terraform#31730

I am mostly concerned with the two first points.
And also feel like this thing should better be addressed as part of another PR?

Wdyt?

[github-actions]

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

[antonbabenko]

This issue has been resolved in version 4.0.0 🎉

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.