fix(main/libidn2): Disable symver aliases. #18758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building libidn2 currently fails at link: ``` make[3]: Entering directory '/home/builder/.termux-build/libidn2/build/lib' // snip CC context.lo CCLD libidn2.la ld.lld: error: .libs/puny_encode.o: symbol _idn2_punycode_encode@IDN2_0.0.0 has undefined version IDN2_0.0.0 ld.lld: error: .libs/puny_decode.o: symbol _idn2_punycode_decode@IDN2_0.0.0 has undefined version IDN2_0.0.0 clang-17: error: linker command failed with exit code 1 (use -v to see invocation) make[3]: *** [Makefile:1609: libidn2.la] Error 1 ``` This fix is recommended here[0]. I couldn't figure out a cleaner way to do this. It would have been a more stable patch against `config.ac`, but `configure` is included in the source tarball and this seemed like the lesser evil. I manually built all packages explicitly depending on libidn2 with this patch applied: gnunet gnurl html-xml-utils lftp libcurl libgmime libgnutls libknot libpsl msmtp wget2 wget whois `gnunet` and `wget2` fail with an apparently unrelated issue: ``` ld.lld: error: version script assignment of 'LIBCTF_1.0' to symbol 'ctf_label_set' failed: symbol not defined ld.lld: error: version script assignment of 'LIBCTF_1.0' to symbol 'ctf_label_get' failed: symbol not defined ``` `libgmime` hangs building `termux-am`. The rest build fine. [0] https://www.mail-archive.com/[email protected]/msg01356.html
|
The |
tstein
added a commit
to tstein/termux-packages
that referenced
this pull request
Dec 24, 2023
…ilding. Saw this in termux#18758. llvm appears to have upgraded a warning to an error (https://reviews.llvm.org/D135402), and while they're not wrong to do so, this package and others (rust-lang/rust#105967) depended on it. This is the simple fix, per the llvm reviews link. Fixes termux#18750.
licy183
pushed a commit
that referenced
this pull request
Dec 25, 2023
…18813) Saw this in #18758. llvm appears to have upgraded a warning to an error (https://reviews.llvm.org/D135402), and while they're not wrong to do so, this package and others (rust-lang/rust#105967) depended on it. This is the simple fix, per the llvm reviews link. Fixes #18750 [skip ci]
|
Thanks! |
xMeM
pushed a commit
to xMeM/termux-packages
that referenced
this pull request
Jan 29, 2024
Building libidn2 currently fails at link: ``` make[3]: Entering directory '/home/builder/.termux-build/libidn2/build/lib' // snip CC context.lo CCLD libidn2.la ld.lld: error: .libs/puny_encode.o: symbol _idn2_punycode_encode@IDN2_0.0.0 has undefined version IDN2_0.0.0 ld.lld: error: .libs/puny_decode.o: symbol _idn2_punycode_decode@IDN2_0.0.0 has undefined version IDN2_0.0.0 clang-17: error: linker command failed with exit code 1 (use -v to see invocation) make[3]: *** [Makefile:1609: libidn2.la] Error 1 ``` This fix is recommended here [0]. I couldn't figure out a cleaner way to do this. It would have been a more stable patch against `config.ac`, but `configure` is included in the source tarball and this seemed like the lesser evil. [0] https://www.mail-archive.com/[email protected]/msg01356.html [skip ci]
bigbio2002
pushed a commit
to bigbio2002/termux-packages
that referenced
this pull request
Feb 27, 2024
…ermux#18813) Saw this in termux#18758. llvm appears to have upgraded a warning to an error (https://reviews.llvm.org/D135402), and while they're not wrong to do so, this package and others (rust-lang/rust#105967) depended on it. This is the simple fix, per the llvm reviews link. Fixes termux#18750 [skip ci]
bigbio2002
pushed a commit
to bigbio2002/termux-packages
that referenced
this pull request
Feb 27, 2024
Building libidn2 currently fails at link: ``` make[3]: Entering directory '/home/builder/.termux-build/libidn2/build/lib' // snip CC context.lo CCLD libidn2.la ld.lld: error: .libs/puny_encode.o: symbol _idn2_punycode_encode@IDN2_0.0.0 has undefined version IDN2_0.0.0 ld.lld: error: .libs/puny_decode.o: symbol _idn2_punycode_decode@IDN2_0.0.0 has undefined version IDN2_0.0.0 clang-17: error: linker command failed with exit code 1 (use -v to see invocation) make[3]: *** [Makefile:1609: libidn2.la] Error 1 ``` This fix is recommended here [0]. I couldn't figure out a cleaner way to do this. It would have been a more stable patch against `config.ac`, but `configure` is included in the source tarball and this seemed like the lesser evil. [0] https://www.mail-archive.com/[email protected]/msg01356.html [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building
libidn2currently fails at link:This fix is recommended here[0]. I couldn't figure out a cleaner way to
do this. It would have been a more stable patch against
config.ac, butconfigureis included in the source tarball and this seemed like thelesser evil. I manually built all packages explicitly depending on
libidn2with this patch applied:gnunetandwget2fail with an apparently unrelated issue:libgmimehangs buildingtermux-am. The rest build fine.[0] https://www.mail-archive.com/[email protected]/msg01356.html