Skip to content

Commit

Permalink
fix(main/libidn2): disable symver aliases (termux#18758)
Browse files Browse the repository at this point in the history
Building libidn2 currently fails at link:

```
make[3]: Entering directory '/home/builder/.termux-build/libidn2/build/lib'
  // snip
  CC       context.lo
  CCLD     libidn2.la
ld.lld: error: .libs/puny_encode.o: symbol _idn2_punycode_encode@IDN2_0.0.0 has undefined version IDN2_0.0.0
ld.lld: error: .libs/puny_decode.o: symbol _idn2_punycode_decode@IDN2_0.0.0 has undefined version IDN2_0.0.0
clang-17: error: linker command failed with exit code 1 (use -v to see invocation)
make[3]: *** [Makefile:1609: libidn2.la] Error 1
```

This fix is recommended here [0]. I couldn't figure out a cleaner way to
do this. It would have been a more stable patch against `config.ac`, but
`configure` is included in the source tarball and this seemed like the
lesser evil. 

[0] https://www.mail-archive.com/[email protected]/msg01356.html

[skip ci]
  • Loading branch information
tstein authored and Harry Weinstein committed Feb 27, 2024
1 parent f460070 commit ad9f5c1
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions packages/libidn2/0000-disable-versioning-of-symbols.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
--- src/configure
+++ src/configure
@@ -32898,8 +32898,6 @@
if ac_fn_c_try_compile "$LINENO"
then :

-printf "%s\n" "#define HAVE_SYMVER_ALIAS_SUPPORT 1" >>confdefs.h
-
fi
rm -f core conftest.err conftest.$ac_objext conftest.beam conftest.$ac_ext

0 comments on commit ad9f5c1

Please sign in to comment.