Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-empty label preference in backed lead list #163

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

rabauss
Copy link
Contributor

@rabauss rabauss commented Nov 26, 2024

Fixes #162 with incorrect label resolution in the label listener when label and value data are arrays.

Previously, the label listener incorrectly handled label and value data provided as arrays. This PR ensures that the correct label is used by iterating over both arrays and prioritizing non-empty labels.

@aschempp aschempp merged commit de533d4 into terminal42:main Dec 18, 2024
1 check failed
@aschempp
Copy link
Member

Thank you @rabauss

@rabauss rabauss deleted the hotfix/label-array branch December 18, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefer label not working for arrays
2 participants