Fix non-empty label preference in backed lead list (#163)

terminal42 · Dec 18, 2024 · de533d4 · de533d4
1 parent 1aa3063
commit de533d4
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/src/EventListener/DataContainer/LeadLabelListener.php b/src/EventListener/DataContainer/LeadLabelListener.php
@@ -48,10 +48,22 @@ public function __invoke(array $row, string $label): string
         $records = $this->connection->fetchAllAssociative('SELECT name, value, label FROM tl_lead_data WHERE pid=?', [$row['id']]);
 
         foreach ($records as $record) {
+            // Try to use label over value if it is a non-empty scalar value or a non-empty array
+            foreach ([$record['label'], $record['value']] as $value) {
+                $value = StringUtil::deserialize($value);
+
+                if (
+                    (!\is_array($value) && '' !== (string) $value)
+                    || (\is_array($value) && [] !== array_filter($value))
+                ) {
+                    break;
+                }
+            }
+
             if ($this->stringParser) {
-                $this->stringParser->flatten(StringUtil::deserialize($record['label'] ?: $record['value']), $record['name'], $tokens);
+                $this->stringParser->flatten($value, $record['name'], $tokens);
             } else {
-                \Haste\Util\StringUtil::flatten(StringUtil::deserialize($record['label'] ?: $record['value']), $record['name'], $tokens);
+                \Haste\Util\StringUtil::flatten($value, $record['name'], $tokens);
             }
         }