Add ttnn runtime layout comparisons in debug mode, minor runtime build cleanup #2338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnie-TT
requested review from
tapspatel,
nsmithtt,
kmabeeTT,
AleksKnezevic,
pilkicTT,
sdjordjevicTT,
svuckovicTT,
mtopalovicTT,
jserbedzijaTT and
azecevicTT
as code owners
azecevicTT
approved these changes
Mar 1, 2025
svuckovicTT
approved these changes
Mar 3, 2025
Comment on lines
+1
to
+4
| if (NOT TTNN_RUNTIME_ENABLED) | ||
| add_library(TTRuntimeTTNNOps INTERFACE) | ||
| return() | ||
| endif() |
There was a problem hiding this comment.
I'm confused, why the NOT in the condition?
There was a problem hiding this comment.
If ttnn runtime is not enabled, we won't build TTRuntimeTTNNOps lib, we'll just add a placeholder interface library that's empty. Only if ttnn runtime is enabled will we actually build the static library
There was a problem hiding this comment.
Can you add a comment please?
jnie-TT
force-pushed
the
jnie/runtime_debug_tensor_compare
branch
5 times, most recently
from
c5cd973 to
c4b879e
Compare
jnie-TT
force-pushed
the
jnie/runtime_debug_tensor_compare
branch
from
c4b879e to
6d634ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
closes #1313
Part of #2125
Problem description
Currently we have don't have a consistency checker that verifies runtime intermediates are aligned with compiler generated descriptors.
What's changed
This PR adds a debug API (only enabled with
-DTT_RUNTIME_DEBUG=ON) that compares every runtime tensor with its corresponding flatbuffer descriptor, checking that layouts, memory configs, data types match.Couple mismatches were found, needed to update the following to fix the mismatches:
TTNNDecomposeLayouts, remove all direct calls to createOp, use the dedicated op creation API instead so that the intermediate layouts are correctTTNNLayouts, set the default layout of the dps operand of conv2d op to tilized instead of forcing to row major.Also added some minor updates in the cmake files under runtime
Checklist