-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1683: Updated memory collection and report of dram and l1 using new metal APIs #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tapspatel
requested review from
nsmithtt,
jnie-TT,
kmabeeTT,
AleksKnezevic and
pilkicTT
as code owners
January 7, 2025 23:39
Dependent on: tenstorrent/tt-metal#16368 |
tapspatel
force-pushed
the
tpatel/issue-1683
branch
2 times, most recently
from
January 8, 2025 00:47
7757540
to
b72971d
Compare
nsmithtt
reviewed
Jan 9, 2025
jnie-TT
reviewed
Jan 10, 2025
tapspatel
force-pushed
the
tpatel/issue-1683
branch
from
January 14, 2025 23:14
b72971d
to
b67f652
Compare
updated APIs to print dram, l1, l1_small and trace memory dumps |
jnie-TT
reviewed
Jan 15, 2025
jnie-TT
reviewed
Jan 15, 2025
jnie-TT
approved these changes
Jan 15, 2025
kmabeeTT
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Taps!
nsmithtt
approved these changes
Jan 15, 2025
tapspatel
force-pushed
the
tpatel/issue-1683
branch
from
January 16, 2025 15:39
b67f652
to
d8bbeb0
Compare
tapspatel
force-pushed
the
tpatel/issue-1683
branch
from
January 16, 2025 17:25
d8bbeb0
to
0500280
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will dump a memory json report after every op execution with the following structure for every device in meshDevice