-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#16367: Added support to enable dram and l1 memory collection without saving to disk #16368
Conversation
81f8df5
to
eb4efbd
Compare
eb4efbd
to
87f69ab
Compare
@abhullar-tt @ayerofieiev-tt I updated the variable names
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall looks okay to me, please post successful CI runs before merging
post commit pipeline pass: https://github.com/tenstorrent/tt-metal/actions/runs/12660580219 |
87f69ab
to
8905345
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me, but I am not sure why we need dedicated user APIs for each buffer type, instead of just taking the buffer type as a parameter.
8905345
to
c2a216c
Compare
@tt-aho agree with your comments. updated the API structure to pass BufferType as a var (l1, dram, l1_small, trace) |
745dc8a
to
affbc66
Compare
post commit pass: https://github.com/tenstorrent/tt-metal/actions/runs/12683308047 |
affbc66
to
7bb435c
Compare
7bb435c
to
9c7cb9c
Compare
9c7cb9c
to
be02763
Compare
Ticket
Link to Github Issue
Problem description
In upstream compiler environments, we need the ability to query a memory view of the device state for DRAM/L1. The current method of saving to csv brings up 2 issues
Current memory allocator csv file:
What's changed
2 new tt_metal APIs
MemoryView GetDramMemoryView(const Device* device);
MemoryView GetL1MemoryView(const Device* device);
2 new ttnn pybinded APIs
ttnn.get_dram_memory_view(device)
ttnn.get_l1_memory_view(device)
Sample usage from ttnn python POV
MemoryView information being collected
Checklist
post commit pass: https://github.com/tenstorrent/tt-metal/actions/runs/12683308047
nightly model and ttnn pass: https://github.com/tenstorrent/tt-metal/actions/runs/12683309017