Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[webgl] Bump types dependency and remove from core. #4109

Merged
merged 1 commit into from
Oct 22, 2020
Merged

[webgl] Bump types dependency and remove from core. #4109

merged 1 commit into from
Oct 22, 2020

Conversation

annxingyuan
Copy link
Contributor

@annxingyuan annxingyuan commented Oct 22, 2020 •
edited
Loading

Fixes #2007

Reference: #2988

This change is Reviewable

@google-cla google-cla bot added the cla: yes label Oct 22, 2020
tafsiri
tafsiri approved these changes Oct 22, 2020
View reviewed changes
Copy link
Contributor

@tafsiri tafsiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ann!

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @tafsiri)

@annxingyuan annxingyuan merged commit 09f0a8f into master Oct 22, 2020
@annxingyuan annxingyuan deleted the webgl_types branch October 22, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tafsiri tafsiri tafsiri approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compile error with TypeScript 3.6
2 participants
@annxingyuan @tafsiri