-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump @types/webgl2 from 0.0.4 to 0.0.5 in /tfjs-core #2988
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
is there any way to help with this? |
Can someone take a look at this one? AFAICS, it's a simple fix to #2007 (which for some reason is closed, but the issue still exists) |
Thank you @hybridmuse ! Would you mind also running cc @tafsiri |
@annxingyuan given the age of this PR, would you want to push a commit to it with the updated package.json/lock file. |
Also, @annxingyuan do we need these types here after the split out of the webgl backend? |
Thanks for the contribution. I think this has been done in another PR. |
Fixes #2007
This change is