-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.15.1 patch release #6674
Merged
Merged
2.15.1 patch release #6674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ow#6658) ## Motivation for features / changes Issue number 5 in tensorflow#6651. It is also just a better experience to keep previously loaded data intact while fetching new data. ## Technical description of changes In order to put the spinner below the headers I added the spinner to the data-table. It seems like a general feature that should be in that widget anyway. ## Screenshots of UI changes (or N/A) ![2023-10-20_15-13-34 (1)](https://github.com/tensorflow/tensorboard/assets/8672809/23bfa0ed-077c-45fb-9df5-a0c3db1db67d)
## Motivation for features / changes The new mat-button uses different colors in it's styling. This caused a readability problem with our Next and Prev buttons when enabled. This fixes the buttons to be readable and look nice. We decided the transparent background looked nice in dark mode but not in light mode. This was brought to our attention in tensorflow#6651. ## Screenshots of UI changes (or N/A) Before: <img width="905" alt="Screenshot 2023-10-20 at 11 22 09 AM" src="https://github.com/tensorflow/tensorboard/assets/8672809/ffad969c-4fa0-4f45-af80-0975a5ad2756"> <img width="897" alt="Screenshot 2023-10-20 at 11 22 17 AM" src="https://github.com/tensorflow/tensorboard/assets/8672809/5fc01f59-7e6c-407d-929b-aac6bdcf0ac6"> After: <img width="868" alt="Screenshot 2023-10-20 at 11 00 38 AM" src="https://github.com/tensorflow/tensorboard/assets/8672809/e8000574-910e-4fef-bb44-26b4faeb5966"> <img width="887" alt="Screenshot 2023-10-20 at 11 13 09 AM" src="https://github.com/tensorflow/tensorboard/assets/8672809/18b821d0-1942-43cd-a501-5d5b7549a8a6"> ## Alternate designs / implementations considered (or N/A) Also considered having a transparent background in light mode.
Remove the experimental API that generates pandas data frames from TensorBoard.dev data. We are turning down TensorBoard.dev.
…ensorflow#6638) In this step of the TensorBoard.dev turndown, we remove the ability to upload via the `tensorboard dev upload` command. Instead, when a user invokes `tensorboard dev upload`, we print the following message, which is similar to the message we currently return in the server info from TensorBoard.dev backends: ``` **************************************************************** **************************************************************** **************************************************************** Uploading TensorBoard logs to https://tensorboard.dev/ is no longer supported. TensorBoard.dev is shutting down. Please export your experiments by Dec 31, 2023. See the FAQ at https://tensorboard.dev. **************************************************************** **************************************************************** **************************************************************** ``` We also remove a bunch of upload-specific code. Testing: I tested the changes by trying some version of the following commands: `bazel run tensorboard -- dev auth revoke` `bazel run tensorboard -- dev upload` `bazel run tensorboard -- dev list` `bazel run tensorboard -- dev update-metadata` `bazel run tensorboard -- dev delete` `bazel run tensorboard -- dev export`
…ensorflow#6656) ## Motivation for features / changes The runs table previously always showed the scroll bar. Now it only shows when there are enough runs. ## Screenshots of UI changes (or N/A) Before (no scroll): ![image](https://github.com/tensorflow/tensorboard/assets/78179109/ab6f197e-1494-4c3a-b11d-88e181860e8b) Before (with scroll): ![image](https://github.com/tensorflow/tensorboard/assets/78179109/ff5908ee-5a75-4153-9a93-d541c5980d51) After (no scroll): ![image](https://github.com/tensorflow/tensorboard/assets/78179109/e287cf02-8cc2-4386-baee-505a5b406266) After (with scroll): ![image](https://github.com/tensorflow/tensorboard/assets/78179109/78c45e94-38aa-4997-971d-d7148d548bda)
## Motivation for features / changes We have been treating all run names as strings even though some run names are (serialized) numbers and some begin with numbers. This means that sorting worked pretty unintuitively. Note: I've also changed the behavior around sorting `undefined` values. When sorting descending they should now appear at the top of the list. This was a recent change but it wasn't clear it was intentional and I found it made the code more complex. tensorflow#6651 Internal users see [b/278671226](http://b/278671226) ## Screenshots of UI changes (or N/A) Before: ![image](https://github.com/tensorflow/tensorboard/assets/78179109/5f805c37-283d-4f55-b1bf-3dfa4d9ea1da) After: ![image](https://github.com/tensorflow/tensorboard/assets/78179109/0d740b6e-2ed5-4762-aec0-22400eeb152d) ![image](https://github.com/tensorflow/tensorboard/assets/78179109/5283bade-b4da-401d-9893-932d9fb9d378)
rileyajones
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch release of TensorBoard with the following cherry-picks from master:
tensorboard dev upload
. #6638)I will rebase and merge the commits.