MDCMigration: Fix prev and next buttons for dark mode #6663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rileyajones
approved these changes
Oct 23, 2023
bmd3k
pushed a commit
to bmd3k/tensorboard
that referenced
this pull request
Nov 2, 2023
## Motivation for features / changes The new mat-button uses different colors in it's styling. This caused a readability problem with our Next and Prev buttons when enabled. This fixes the buttons to be readable and look nice. We decided the transparent background looked nice in dark mode but not in light mode. This was brought to our attention in tensorflow#6651. ## Screenshots of UI changes (or N/A) Before: <img width="905" alt="Screenshot 2023-10-20 at 11 22 09 AM" src="https://github.com/tensorflow/tensorboard/assets/8672809/ffad969c-4fa0-4f45-af80-0975a5ad2756"> <img width="897" alt="Screenshot 2023-10-20 at 11 22 17 AM" src="https://github.com/tensorflow/tensorboard/assets/8672809/5fc01f59-7e6c-407d-929b-aac6bdcf0ac6"> After: <img width="868" alt="Screenshot 2023-10-20 at 11 00 38 AM" src="https://github.com/tensorflow/tensorboard/assets/8672809/e8000574-910e-4fef-bb44-26b4faeb5966"> <img width="887" alt="Screenshot 2023-10-20 at 11 13 09 AM" src="https://github.com/tensorflow/tensorboard/assets/8672809/18b821d0-1942-43cd-a501-5d5b7549a8a6"> ## Alternate designs / implementations considered (or N/A) Also considered having a transparent background in light mode.
Merged
bmd3k
pushed a commit
that referenced
this pull request
Nov 2, 2023
## Motivation for features / changes The new mat-button uses different colors in it's styling. This caused a readability problem with our Next and Prev buttons when enabled. This fixes the buttons to be readable and look nice. We decided the transparent background looked nice in dark mode but not in light mode. This was brought to our attention in #6651. ## Screenshots of UI changes (or N/A) Before: <img width="905" alt="Screenshot 2023-10-20 at 11 22 09 AM" src="https://github.com/tensorflow/tensorboard/assets/8672809/ffad969c-4fa0-4f45-af80-0975a5ad2756"> <img width="897" alt="Screenshot 2023-10-20 at 11 22 17 AM" src="https://github.com/tensorflow/tensorboard/assets/8672809/5fc01f59-7e6c-407d-929b-aac6bdcf0ac6"> After: <img width="868" alt="Screenshot 2023-10-20 at 11 00 38 AM" src="https://github.com/tensorflow/tensorboard/assets/8672809/e8000574-910e-4fef-bb44-26b4faeb5966"> <img width="887" alt="Screenshot 2023-10-20 at 11 13 09 AM" src="https://github.com/tensorflow/tensorboard/assets/8672809/18b821d0-1942-43cd-a501-5d5b7549a8a6"> ## Alternate designs / implementations considered (or N/A) Also considered having a transparent background in light mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
The new mat-button uses different colors in it's styling. This caused a readability problem with our Next and Prev buttons when enabled. This fixes the buttons to be readable and look nice. We decided the transparent background looked nice in dark mode but not in light mode.
This was brought to our attention in #6651.
Screenshots of UI changes (or N/A)
Before:
After:
Alternate designs / implementations considered (or N/A)
Also considered having a transparent background in light mode.