-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove %tensorflow_version 2.x
directives
#3459
Conversation
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
For context, this supersedes #3452. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks nearly correct. Could you please merge master to pick
up CI changes and also fix stale outputs (see inlines)?
@@ -90,12 +90,6 @@ | |||
} | |||
], | |||
"source": [ | |||
"try:\n", | |||
" # %tensorflow_version only exists in Colab.\n", | |||
" %tensorflow_version 2.x\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This output cell is stale, right?
"outputs": [
{
"name": "stdout",
"output_type": "stream",
"text": [
"TensorFlow 2.x selected.\n"
]
}
],
Likewise in other notebooks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint check is still failing; please run through nbfmt.py
.
%tensorflow_version 1.x
directives
%tensorflow_version 1.x
directives%tensorflow_version 2.x
directives
Thanks for the contribution! |
Colab now uses TensorFlow 2.x by default, so `%tensorflow_version 2.x` is no longer required. Fixes tensorflow#3451.
Colab now uses TensorFlow 2.x by default, so `%tensorflow_version 2.x` is no longer required. Fixes #3451.
Fixes : #3451
@wchargin Plz review this PR