-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed redundant lines from get_started.ipynb
#3452
Conversation
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request!
There are a lot of extraneous changes in the output here due to
re-running the whole notebook. Only 5–10 lines actually need to be
changed, but this diff touches 526 lines, which makes it hard to see
what the patch actually does. Could you please revert those extraneous
changes? The GitHub diff viewer should be able to comfortably show the
change rather than complaining that the diff is too large.
Also, it looks like there are more uses of %tensorflow_version 2.x
in
the rest of the docs:
$ git grep '%tensorflow_version 2'
docs/graphs.ipynb: " %tensorflow_version 2.x\n",
docs/hyperparameter_tuning_with_hparams.ipynb: " %tensorflow_version 2.x\n",
docs/image_summaries.ipynb: " %tensorflow_version 2.x\n",
docs/migrate.ipynb: " %tensorflow_version 2.x\n",
docs/migrate.ipynb: " %tensorflow_version 2.x\n",
docs/scalars_and_keras.ipynb: " %tensorflow_version 2.x\n",
docs/tbdev_getting_started.ipynb: " %tensorflow_version 2.x\n",
docs/tensorboard_in_notebooks.ipynb: " %tensorflow_version 2.x\n",
It’d be best to fix all of them in the same PR. Can you update this
patch to include changes to those files, too?
Hi @ManishAradwad , to make the diffs easier to read, you can try running the notebook through nbfmt.py or downloading from Colab. |
@lamberta: Thanks for the pointer to |
@wchargin Cool, let me know how it goes. Now looking at ways to integrate it into the GitHub CI to reduce friction for tensorflow/docs PRs |
Opened #3455, which does integrate into GitHub Actions. It’s pretty |
@ManishAradwad: I’ve merged #3455; please feel free to update this PR |
@wchargin Thanks for the review. I'm unable to resolve the conflicts of this branch with the master branch(apparently the nb is not opening in vscode). I think to avoid any complexity, it would be better if I close this PR and open another one. I'll send one soon. |
Fixes : #3451
@lamberta Can you plz review this PR.