pip: fix smoke test double-TensorBoard dependency #2211
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The smoke test doesn’t actually catch those things that it’s supposed to
catch, because it installs
tf-nightly
(ortf-nightly-2.0-preview
),which in turn installs
tb-nightly
. We then install the just-builtversion of
tensorboard
, so the resulting virtualenv has bothtensorboard
andtb-nightly
: #1907 strikes again.When
--tf-version ""
is passed, this is not an issue, but some smokechecks only run when that is not passed.
It just so happens that this is currently benign: each of the direct
dependencies of
:build_pip_package
either has no smoke test, containsan
__init__.py
file that is required to overwrite the Bazel-generatedempty one, because the smoke test references symbols directly in that
file, or is not yet in
tb-nightly
. But (a) starting with tomorrow’snightly, the mesh smoke test will meet none of those conditions, so its
smoke test will cease to be effective, and (b) I’d like to add an
hparams smoke test, which already falls into the same boat.
Test Plan:
Add an hparams smoke test, but remove the actual hparams dep:
Then run
and note that the smoke test passes (incorrectly) before this commit and
fails (correctly) after it.
Note also that the
pip freeze
output from the smoke test includes bothtb-nightly
andtensorboard
before this change (e.g., on recentTravis logs), but only
tensorboard
after it.wchargin-branch: pip-smoke-2dep