Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesh: explictly define public API, for consistency #2208

Merged
merged 1 commit into from
May 7, 2019
Merged

mesh: explictly define public API, for consistency #2208

merged 1 commit into from
May 7, 2019

Conversation

wchargin
Copy link
Contributor

@wchargin wchargin commented May 7, 2019

Summary:
Amends #2205 to be consistent with other plugins.

Test Plan:
Pip package smoke test still passes.

wchargin-branch: mesh-library-target

@wchargin
mesh: explictly define public API, for consistency
be63b8b 
Summary:
Amends #2205 to be consistent with other plugins.

Test Plan:
Pip package smoke test still passes.

wchargin-branch: mesh-library-target
@wchargin wchargin requested a review from stephanwlee May 7, 2019 19:41
nfelt
nfelt approved these changes May 7, 2019
View reviewed changes
Copy link
Contributor

@nfelt nfelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're amending, want to add a line in the smoke test for the hparams public API as mentioned on #2205 for mesh?

@wchargin
Copy link
Contributor Author

wchargin commented May 7, 2019

@nfelt: I’d love to, but unfortunately the smoke test is currently
broken in a way that makes that test unfalsifiable. See #2211 for the
fix.

@wchargin wchargin merged commit a4b2a20 into master May 7, 2019
@wchargin wchargin deleted the wchargin-mesh-library-target branch May 7, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanwlee stephanwlee stephanwlee approved these changes

@nfelt nfelt nfelt approved these changes

Assignees
No one assigned
Labels
plugin:mesh type:cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wchargin @nfelt @stephanwlee