build: lock down visibility of unversioned summary targets #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: We’ve migrated all users inside Google to use the explicitly versioned endpoints (either `summary:summary_v1` or `summary:summary_v2`), so we can now enforce that going forward. Any existing users should migrate to `//tensorboard/summary:summary_v1`, which is API-compatible and stable. Test Plan: That `bazel build //tensorboard` and `bazel query 'deps(//...)'` still work suffices. wchargin-branch: restrict-summary-visibility
nfelt
approved these changes
Jan 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We’ve migrated all users inside Google to use the explicitly versioned
endpoints (either
summary:summary_v1orsummary:summary_v2), so wecan now enforce that going forward.
Any existing users should migrate to
//tensorboard/summary:summary_v1,which is API-compatible and stable.
Test Plan:
That
bazel build //tensorboardandbazel query 'deps(//...)'stillwork suffices.
wchargin-branch: restrict-summary-visibility