Skip to content

Commit

Permalink
build: lock down visibility of unversioned summary targets (#1769)
Browse files Browse the repository at this point in the history
Summary:
We’ve migrated all users inside Google to use the explicitly versioned
endpoints (either `summary:summary_v1` or `summary:summary_v2`), so we
can now enforce that going forward.

Any existing users should migrate to `//tensorboard/summary:summary_v1`,
which is API-compatible and stable.

Test Plan:
That `bazel build //tensorboard` and `bazel query 'deps(//...)'` still
work suffices.

wchargin-branch: restrict-summary-visibility
  • Loading branch information
wchargin authored Jan 17, 2019
1 parent 90171c4 commit 3a42560
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tensorboard/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ py_test(
alias(
name = "summary",
actual = "//tensorboard/summary",
visibility = ["//visibility:public"],
visibility = ["//tensorboard:internal"],
)

py_library(
Expand Down
2 changes: 1 addition & 1 deletion tensorboard/summary/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ py_library(
"__init__.py",
],
srcs_version = "PY2AND3",
visibility = ["//visibility:public"],
visibility = ["//tensorboard:internal"],
deps = [
":summary_v1",
":summary_v2",
Expand Down

0 comments on commit 3a42560

Please sign in to comment.