build: unpin tf-nightly version #1761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This reverts part of d285c7d because the upstream package has been fixed. Test Plan: Running `from tensorflow.compat import v1` fails in the 20190114 virtualenv but works in the 20190115 virtualenv. Building the Pip package with `bazel run //tensorboard/pip_package:build_pip_package` also works. wchargin-branch: unpin-tf-nightly
|
Welp, we’re hitting I’ll re-run on a prayer, and then probably have to figure out an actual |
nfelt
approved these changes
Jan 15, 2019
wchargin-branch: unpin-tf-nightly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This reverts part of d285c7d because
the upstream package has been fixed.
Test Plan:
Running
from tensorflow.compat import v1fails in the 20190114virtualenv but works in the 20190115 virtualenv. Building the Pip
package with
bazel run //tensorboard/pip_package:build_pip_packagealso works.
wchargin-branch: unpin-tf-nightly