Skip to content

Commit

Permalink
build: unpin tf-nightly version (#1761)
Browse files Browse the repository at this point in the history
Summary:
This reverts part of d285c7d because
the upstream package has been fixed.

Test Plan:
Running `from tensorflow.compat import v1` fails in the 20190114
virtualenv but works in the 20190115 virtualenv. Building the Pip
package with `bazel run //tensorboard/pip_package:build_pip_package`
also works.

wchargin-branch: unpin-tf-nightly
  • Loading branch information
wchargin authored Jan 17, 2019
1 parent fad69e5 commit f803d16
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,7 @@ install:
pip install -I tensorflow
;;
NIGHTLY)
# TODO(@wchargin): Unpin once tensorflow/tensorflow#24867 is merged:
# https://github.com/tensorflow/tensorflow/pull/24867
pip install -I tf-nightly==1.13.0.dev20190104
pip install -I tf-nightly
;;
*)
pip install -I tensorflow=="${TF}"
Expand Down
4 changes: 1 addition & 3 deletions tensorboard/pip_package/build_pip_package.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,7 @@ while [ "$#" -gt 0 ]; do
done

smoke() {
# TODO(@wchargin): Unpin once tensorflow/tensorflow#24867 is merged:
# https://github.com/tensorflow/tensorflow/pull/24867
TF_PACKAGE=tf-nightly==1.13.0.dev20190104
TF_PACKAGE=tf-nightly
if [ -n "$TF_VERSION" ]; then
TF_PACKAGE="tensorflow==${TF_VERSION}"
fi
Expand Down

0 comments on commit f803d16

Please sign in to comment.