Cleanup: Upgrade lodash and plottable #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanwlee
force-pushed
the
upgrade
branch
2 times, most recently
from
b8a458d
to
31e51e8
Compare
|
Thanks for getting this started! Plottable also upgraded |
nfelt
approved these changes
Aug 9, 2018
- Lodash renamed `pairs` to `toPairs`. - `sortedIndex` renamed to `sortedIndexBy` Unfortunately, type information lacks reference to the new ones so we wrote the POJO version of these utilities at least for now.
More lodash notes:
- `sortByAll` -> `sortBy`
- scope argument in _.map and _.each is deprecated
- .each() evaluates Lodash object right away (i.e.,
_([]).each().value()) is illegal)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pairstotoPairs.sortedIndexrenamed tosortedIndexByUnfortunately, type information lacks reference to the new ones
so we wrote the POJO version of these utilities at least for now.