Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade external Dependencies like Plottable #1329

Closed
2 of 3 tasks
stephanwlee opened this issue Aug 2, 2018 · 1 comment
Closed
2 of 3 tasks

Upgrade external Dependencies like Plottable #1329

stephanwlee opened this issue Aug 2, 2018 · 1 comment

Comments

@stephanwlee
Copy link
Contributor

stephanwlee commented Aug 2, 2018

Context

TensorBoard today (as of 1.10a) is using Plottable 3.1.0 when the latest is at 3.8.3. It brings in few performance optimizations like less measure/mutate operations on mousemove. Specifically, when moving cursor across page on non-chart elements, the Plottable via MouseInteractions spends about ~5ms per frame doing JS+renderer work (remember, we have 16.666ms per frame) that has zero impact on UI.

Action Items

  • [email protected]
    • it breaks tooltip: doesn't scan when moving the mouse across a chart
    • has hard dependency on Lodash 4.17.10 and the bundle pulls in both versions of lodash: it causes few components to break as 3.x and 4.x have non-trivial API changes. i.e., _.pairs -> _.toPairs. Alternatively, we can use Object.entries but it seems to require a change in TS config.
  • Lodash 4.x
    • ??
@stephanwlee
Copy link
Contributor Author

It has been fixed by #1333

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant