Add ffmpeg support for Ubuntu 20.04 and switch to python 3.8 for tests #1195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past only Ubuntu 16.04 and 18.04 are supported for ffmpeg audio/video Dataset. In this PR ffmpeg support for Ubuntu 20.04 has been added as Ubuntu 20.04 has been released this year. Also fix `Invalid return value 0 for stream protocol` issue when LIBAVFORMAT_VERSION_MAJOR > 57 Signed-off-by: Yong Tang <[email protected]>
yongtang
force-pushed
the
ffmpeg-4.2
branch
2 times, most recently
from
b4b0c22 to
8ff30df
Compare
.github/workflows/build.yml
Outdated
| strategy: | ||
| matrix: | ||
| python: ['3.6', '3.7'] | ||
| python: ['3.8'] |
Member
There was a problem hiding this comment.
@yongtang maybe we can test with 3.7 and 3.8? Just to be sure of the compatibility as users might still be using 3.7.
In the past we use python 3.6/3.7 as the default version for testing as some packages for testing are not available for 3.8 yet, even though many python systems have been upgraded to 3.8. For example, Ubuntu 20.04 and macOS's default system pythons are already 3.8. This PR switches to use python 3.8 for testings. This should also reduce GitHub Actions jobs a little bit. This PR also updates ffmpeg video samples (as there is a small different between Ubuntu 18.04 and Ubuntu 20.04 ffmpeg) Signed-off-by: Yong Tang <[email protected]>
Signed-off-by: Yong Tang <[email protected]>
kvignesh1420
approved these changes
Nov 16, 2020
terrytangyuan
approved these changes
Nov 16, 2020
i-ony
pushed a commit
to i-ony/io
that referenced
this pull request
Feb 8, 2021
tensorflow#1195) * Add ffmpeg support for Ubuntu 20.04 In the past only Ubuntu 16.04 and 18.04 are supported for ffmpeg audio/video Dataset. In this PR ffmpeg support for Ubuntu 20.04 has been added as Ubuntu 20.04 has been released this year. Also fix `Invalid return value 0 for stream protocol` issue when LIBAVFORMAT_VERSION_MAJOR > 57 Signed-off-by: Yong Tang <[email protected]> * Switch to python 3.8 for tests In the past we use python 3.6/3.7 as the default version for testing as some packages for testing are not available for 3.8 yet, even though many python systems have been upgraded to 3.8. For example, Ubuntu 20.04 and macOS's default system pythons are already 3.8. This PR switches to use python 3.8 for testings. This should also reduce GitHub Actions jobs a little bit. This PR also updates ffmpeg video samples (as there is a small different between Ubuntu 18.04 and Ubuntu 20.04 ffmpeg) Signed-off-by: Yong Tang <[email protected]> * Add python3.7 test back, based on review comment Signed-off-by: Yong Tang <[email protected]>
zheolong
pushed a commit
to zheolong/io-1
that referenced
this pull request
Jul 24, 2025
tensorflow#1195) * Add ffmpeg support for Ubuntu 20.04 In the past only Ubuntu 16.04 and 18.04 are supported for ffmpeg audio/video Dataset. In this PR ffmpeg support for Ubuntu 20.04 has been added as Ubuntu 20.04 has been released this year. Also fix `Invalid return value 0 for stream protocol` issue when LIBAVFORMAT_VERSION_MAJOR > 57 Signed-off-by: Yong Tang <[email protected]> * Switch to python 3.8 for tests In the past we use python 3.6/3.7 as the default version for testing as some packages for testing are not available for 3.8 yet, even though many python systems have been upgraded to 3.8. For example, Ubuntu 20.04 and macOS's default system pythons are already 3.8. This PR switches to use python 3.8 for testings. This should also reduce GitHub Actions jobs a little bit. This PR also updates ffmpeg video samples (as there is a small different between Ubuntu 18.04 and Ubuntu 20.04 ffmpeg) Signed-off-by: Yong Tang <[email protected]> * Add python3.7 test back, based on review comment Signed-off-by: Yong Tang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
Add ffmpeg support for Ubuntu 20.04
In the past only Ubuntu 16.04 and 18.04 are supported for ffmpeg audio/video Dataset.
In this PR ffmpeg support for Ubuntu 20.04 has been added as Ubuntu 20.04 has been released this year.
Also fix
Invalid return value 0 for stream protocolissue when LIBAVFORMAT_VERSION_MAJOR > 57Switch to python 3.8 for tests
In the past we use python 3.6/3.7 as the default version for testing as some packages for testing are not available for 3.8 yet, even though many python systems have been upgraded to 3.8. For example, Ubuntu 20.04 and macOS's default system pythons are already 3.8.
This PR switches to use python 3.8 for testings. This should also reduce GitHub Actions jobs a little bit.
This PR also updates ffmpeg video samples (as there is a small different between Ubuntu 18.04 and Ubuntu 20.04 ffmpeg)
Signed-off-by: Yong Tang [email protected]