Skip to content

Commit 8ff30df

Browse files
committed
Switch to python 3.8 for tests
In the past we use python 3.6/3.7 as the default version for testing as some packages for testing are not available for 3.8 yet, even though many python systems have been upgraded to 3.8. For example, Ubuntu 20.04 and macOS's default system pythons are already 3.8. This PR switches to use python 3.8 for testings. This should also reduce GitHub Actions jobs a little bit. This PR also updates ffmpeg video samples (as there is a small different between Ubuntu 18.04 and Ubuntu 20.04 ffmpeg) Signed-off-by: Yong Tang <[email protected]>
1 parent 7f0e1e3 commit 8ff30df

File tree

4 files changed

+6
-16
lines changed

4 files changed

+6
-16
lines changed

.github/workflows/build.wheel.sh

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,6 @@ if [[ "$#" -gt 0 ]]; then
1919
shift
2020
fi
2121

22-
if [[ "$PYTHON_VERSION" == "python3.8" ]]; then
23-
echo "TODO: Python 3.8 test is not supported yet as dependency might not be available"
24-
exit 0
25-
fi
26-
2722
if [[ $(uname) == "Linux" ]]; then
2823
apt-get -y -qq update
2924
if [[ "${PYTHON_VERSION}" == "python3.7" ]]; then

.github/workflows/build.yml

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ jobs:
179179
runs-on: macos-latest
180180
strategy:
181181
matrix:
182-
python: ['3.6', '3.7']
182+
python: ['3.8']
183183
steps:
184184
- uses: actions/checkout@v2
185185
- uses: docker-practice/actions-setup-docker@v1
@@ -275,13 +275,8 @@ jobs:
275275
runs-on: ${{ matrix.os }}
276276
strategy:
277277
matrix:
278-
os: [ubuntu-18.04, ubuntu-20.04]
279-
python: ['3.6', '3.7']
280-
exclude:
281-
- os: ubuntu-20.04
282-
python: '3.6'
283-
- os: ubuntu-20.04
284-
python: '3.7'
278+
os: [ubuntu-20.04]
279+
python: ['3.8']
285280
steps:
286281
- uses: actions/checkout@v2
287282
- uses: actions/download-artifact@v1
@@ -375,7 +370,7 @@ jobs:
375370
runs-on: windows-latest
376371
strategy:
377372
matrix:
378-
python: ['3.6', '3.7']
373+
python: ['3.8']
379374
steps:
380375
- uses: actions/checkout@v2
381376
- uses: actions/download-artifact@v1

.kokorun/io_cpu.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ python --version
4545
python -m pip --version
4646
docker --version
4747

48-
export PYTHON_VERSION=3.7
48+
export PYTHON_VERSION=3.8
4949

5050
export BAZEL_VERSION=$(cat .bazelversion)
5151
export BAZEL_OPTIMIZATION="--copt=-msse4.2 --copt=-mavx --compilation_mode=opt"
@@ -81,7 +81,7 @@ bash -x -e tests/test_sql/sql_test.sh sql
8181
bash -x -e tests/test_elasticsearch/elasticsearch_test.sh start
8282

8383
docker run -i --rm -v $PWD:/v -w /v --net=host \
84-
buildpack-deps:18.04 bash -x -e .github/workflows/build.wheel.sh python${PYTHON_VERSION}
84+
buildpack-deps:20.04 bash -x -e .github/workflows/build.wheel.sh python${PYTHON_VERSION}
8585

8686
## In case there are any files generated by docker with root user
8787
sudo chown -R $(id -nu):$(id -ng) .
0 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)